Bug 563376
| Summary: | Revive from F11 branch: pcmanx-gtk2 - Telnet client designed for BBS browsing | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chen Lei <supercyper1> |
| Component: | Package Review | Assignee: | Robin Lee <robinlee.sysu> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, robinlee.sysu |
| Target Milestone: | --- | Flags: | robinlee.sysu:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-19 02:32:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chen Lei
2010-02-10 01:36:20 UTC
Update to svn523 SPEC: https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2.spec SRPM: https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2-0.3.9-5.20100601svn.fc13.src.rpm Disable xulrunner plugin by default SPEC: https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2.spec SRPM: https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2-0.3.9-5.20100601svn.fc13.src.rpm Wrong URLs? (In reply to comment #2) > Disable xulrunner plugin by default > > SPEC: > https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2.spec > SRPM: > https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2-0.3.9-5.20100601svn.fc13.src.rpm This is an old package and the spec file is well-structured. But it failed to build a binary package: https://koji.fedoraproject.org/koji/taskinfo?taskID=2244897 The %configure command should be something like: %configure --enable-libnotify \ --enable-wget \ --enable-iplookup \ --enable-proxy %{?_with_plugin:--enable-plugin} The fact that the plugin is disabled should be recorded in %changelog . And please change the release number every time you modify your spec file. And some comments should be added on why the plugin is disabled but the building code remains in the spec file. Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig The above lines are not necessary. Though the plugin is now prevented from building, the naming of it is not good. Maybe 'mozilla-pcmanx' is better, with respect to existing similar packages. (In reply to comment #4) > This is an old package and the spec file is well-structured. > But it failed to build a binary package: > https://koji.fedoraproject.org/koji/taskinfo?taskID=2244897 > The %configure command should be something like: > %configure --enable-libnotify \ > --enable-wget \ > --enable-iplookup \ > --enable-proxy %{?_with_plugin:--enable-plugin} > The fact that the plugin is disabled should be recorded in %changelog . > And please change the release number every time you modify your spec file. > And some comments should be added on why the plugin is disabled but the > building code remains in the spec file. Will be fixed in next realse > Requires(post): /sbin/ldconfig > Requires(postun): /sbin/ldconfig > The above lines are not necessary. This is still needed, e.g. {_libdir}/libpcmanx.so.0 > Though the plugin is now prevented from building, the naming of it is not good. > Maybe 'mozilla-pcmanx' is better, with respect to existing similar packages. This package is not pure mozilla plugin, it also contain some xulrunner compenents , see %file xulrunner-plugin (In reply to comment #5) > > Requires(post): /sbin/ldconfig > > Requires(postun): /sbin/ldconfig > > The above lines are not necessary. > This is still needed, e.g. {_libdir}/libpcmanx.so.0 http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Shared_libraries "If applicable, the latter way is recommended because doing so will automatically add appropriate dependencies on /sbin/ldconfig to the package" (In reply to comment #6) > (In reply to comment #5) > > > Requires(post): /sbin/ldconfig > > > Requires(postun): /sbin/ldconfig > > > The above lines are not necessary. > > This is still needed, e.g. {_libdir}/libpcmanx.so.0 > http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Shared_libraries > > "If applicable, the latter way is recommended because doing so will > automatically add appropriate dependencies on /sbin/ldconfig to the package" I can't find those lines on spec, maybe you see it from other spec file? (In reply to comment #7) > I can't find those lines on spec, maybe you see it from other spec file? https://dl-web.dropbox.com/u/1338197/1/pcmanx-gtk2.spec Line 34 and 35. Okay. Rawhide build succeeded: http://koji.fedoraproject.org/koji/taskinfo?taskID=2248524 Now it is approved by cheeselee. Package Change Request ====================== Package Name: pcmanx-gtk2 New Branches: F-12 F-13 Owners: supercyper (In reply to comment #10) > Okay. Rawhide build succeeded: > http://koji.fedoraproject.org/koji/taskinfo?taskID=2248524 > > Now it is approved by cheeselee. Thanks for the review! I believe I've unretired the package and set the ownership properly. Please let me know if something doesn't work properly. (In reply to comment #13) > I believe I've unretired the package and set the ownership properly. Please > let me know if something doesn't work properly. built pcmanx-gtk2 on koji successfully , thanks. |