Bug 563479
| Summary: | Review Request: aduna-commons-text - Manipulate/transform/parse text in various ways | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mary Ellen Foster <mefoster> |
| Component: | Package Review | Assignee: | Mat Booth <mat.booth> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mat.booth:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | aduna-commons-text-2.6.0-3.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-14 13:39:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 561439 | ||
| Bug Blocks: | 567951, 567952 | ||
|
Description
Mary Ellen Foster
2010-02-10 11:40:24 UTC
Updated version with extra BuildRequirement: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text.spec SRPM URL: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text-2.6.0-2.fc12.src.rpm I will take this one. Rpmlint shows:
aduna-commons-text.x86_64: W: no-documentation
aduna-commons-text.x86_64: W: non-conffile-in-etc /etc/maven/fragments/aduna-commons-text
But I'm not worried about that: Upstream does not seem to include a copy of the licence to use as documentation and the other warning is expected because of the maven dep-map fragment.
Overall, this is a very compliant package. The only thing I would suggest is to have something that ensures no pre-compiled classes are shipped in the source jar and used during the build. Not because that is the case with this package, but because it is good practice for Java packages in general.
Something like this in the %prep section would suffice[1]:
find -name '*.class' -exec rm -f '{}' \;
find -name '*.jar' -exec rm -f '{}' \;
[1] Taken from the template in the Java packaging guidelines: http://fedoraproject.org/wiki/Packaging:Java#ant_2
One more thing:
It is usual for sub-packages (i.e. the javadoc package) to have a fully versioned dependency on the main package:
Requires: %{name} = %{version}-%{release}
New version: - Remove BuildRequirements that are pulled in by aduna-commons POM - Require the main package in the javadoc http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text.spec http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text-2.6.0-3.fc12.src.rpm Thanks for the easy review. APPROVED New Package CVS Request ======================= Package Name: aduna-commons-text Short Description: Manipulate/transform/parse text in various ways Owners: mef Branches: F-12 InitialCC: CVS done (by process-cvs-requests.py). I added an F-13 branch as well, since that seems to have been left out. aduna-commons-text-2.6.0-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/aduna-commons-text-2.6.0-3.fc13 aduna-commons-text-2.6.0-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update aduna-commons-text'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3351 aduna-commons-text-2.6.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |