Bug 561439 - Review Request: aduna-commons-pom - Aduna Commons parent pom
Summary: Review Request: aduna-commons-pom - Aduna Commons parent pom
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Adam Goode
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 563477 563479 563480 563481 563483
TreeView+ depends on / blocked
 
Reported: 2010-02-03 16:36 UTC by Mary Ellen Foster
Modified: 2010-03-16 00:47 UTC (History)
3 users (show)

Fixed In Version: aduna-commons-pom-16-1.fc12
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-16 00:47:30 UTC
adam: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Mary Ellen Foster 2010-02-03 16:36:13 UTC
Spec URL: http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-pom.spec
SRPM URL:
http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-pom-16-1.src.rpm

Description:
This package provides the parent POM for all aduna-commons packages

Comment 1 Adam Goode 2010-02-10 04:37:58 UTC
rpmlint:

aduna-commons-pom.noarch: W: no-documentation
aduna-commons-pom.noarch: W: non-conffile-in-etc /etc/maven/fragments/aduna-commons-pom
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Seems ok.


All MUSTs pass.

A few comments:

 * Consider using cp -a or something like that to preserve the timestamps in %prep.
 * Consider including the upstream license as a source and put into %doc.

All other SHOULDs look good.


Also, the SRPM wasn't in the right place, I had to dig around in the webspace for it.

Comment 2 Adam Goode 2010-02-10 04:40:41 UTC
ACCEPT

Comment 3 Mary Ellen Foster 2010-02-10 10:55:00 UTC
New Package CVS Request
=======================
Package Name: aduna-commons-pom
Short Description: Aduna commons parent POM
Owners: mef
Branches: F-12

Comment 4 Kevin Fenzi 2010-02-11 06:23:08 UTC
CVS done (by process-cvs-requests.py).

Comment 5 Fedora Update System 2010-02-11 09:53:49 UTC
aduna-commons-pom-16-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/aduna-commons-pom-16-1.fc12

Comment 6 Fedora Update System 2010-02-12 04:45:28 UTC
aduna-commons-pom-16-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update aduna-commons-pom'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1796

Comment 7 Fedora Update System 2010-03-16 00:47:25 UTC
aduna-commons-pom-16-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.