Bug 563480

Updated version with extra BuildRequirement:

http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text.spec
SRPM URL:
http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-text-2.6.0-2.fc12.src.rpm

I will take this one.

I assume you meant to post a link to aduna-commons-concurrent-2.6.0-2, rather than aduna-commons-text-2.6.0-2 ;-)

Rpmlint shows:

aduna-commons-text.x86_64: W: no-documentation
aduna-commons-text.x86_64: W: non-conffile-in-etc
/etc/maven/fragments/aduna-commons-text

But I'm not worried about that: Upstream does not seem to include a copy of the
licence to use as documentation and the other warning is expected because of
the maven dep-map fragment.

Overall, this is a very compliant package. Two things I would suggest are:

1. To have something that ensures no pre-compiled classes are shipped in the source jar and used during the build. Not because that is the case with this package, but because it is good practice for Java packages in general.

Something like this in the %prep section would suffice[1]:

 find -name '*.class' -exec rm -f '{}' \;
 find -name '*.jar' -exec rm -f '{}' \;

2. To note that it is usual for sub-packages (i.e. the javadoc package) to have a fully versioned dependency on the main package:

 Requires: %{name} = %{version}-%{release}


[1] Taken from the template in the Java packaging guidelines:
http://fedoraproject.org/wiki/Packaging:Java#ant_2

New version:
- Remove BuildRequirements that are pulled in by aduna-commons POM
- Require the main package in the javadoc

http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-concurrent.spec
http://www.macs.hw.ac.uk/~mef3/soprano-sesame/aduna-commons-concurrent-2.6.0-3.fc12.src.rpm

You didn't put the

 find -name '*.class' -exec rm -f '{}' \;
 find -name '*.jar' -exec rm -f '{}' \;

blather in, but that's up to you. It isn't a requirement, just a suggestion in the guidelines. I'm happy to approve this.

APPROVED

New Package CVS Request
=======================
Package Name: aduna-commons-concurrent
Short Description: Extensions to the Java Concurrency package
Owners: mef
Branches: F-12
InitialCC:

CVS done (by process-cvs-requests.py).

I added an F-13 branch as well.

aduna-commons-concurrent-2.6.0-3.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/aduna-commons-concurrent-2.6.0-3.fc13

aduna-commons-concurrent-2.6.0-3.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update aduna-commons-concurrent'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F13/FEDORA-2010-3461

aduna-commons-concurrent-2.6.0-3.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.