Bug 563673
| Summary: | Review Request: sil-abyssinica-fonts - SIL Abyssinica fonts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mathieu Bridon <bochecha> |
| Component: | Package Review | Assignee: | Jens Petersen <petersen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, fonts-bugs, i18n-bugs, notting, petersen |
| Target Milestone: | --- | Flags: | petersen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-13 08:16:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 563395, 563399 | ||
|
Description
Mathieu Bridon
2010-02-10 20:49:55 UTC
How about the "Provides: fonts-sil-abyssinica"? (bug 563395) Also can you reproduce: # note current downloaded filename is lowercase and if so how about renaming the source file? Other than that the new package looks fine to me. (In reply to comment #0) > I'm not sure the additional Provides: tag is really necessary as no package > were currently depending on abyssinica-fonts. Yeah, your call I think, but it might not hurt for people familiar with the old name. You might add a comment say "# added for f13 can be removed for f15". Taking the review (since I requested the name change;) Ah also please upload the srpm for reference. :) (In reply to comment #1) > How about the "Provides: fonts-sil-abyssinica"? (bug 563395) I thought I'd not mix this in the renaming, that if I only did the renaming then the review would be easier. I was planning to fix it afterwards, but if you feel like I should fix it in the same time, then let's go :) > Also can you reproduce: > > # note current downloaded filename is lowercase > > and if so how about renaming the source file? I assumed the source tarball had not changed. I'll take a look at it. (In reply to comment #2) > Yeah, your call I think, but it might not hurt for people > familiar with the old name. You might add a comment > say "# added for f13 can be removed for f15". Good idea. I will do that. (In reply to comment #4) > Ah also please upload the srpm for reference. :) Doh, why did I upload the binary rpm instead of the src.rpm ? oÔ I scratch-built it in Koji before uploading it to my FedoraPeople space (I don't know how long scratch builds are kept). Here it is: http://koji.fedoraproject.org/koji/getfile?taskID=1976022&name=sil-abyssinica-fonts-1.0-6.fc13.src.rpm Anyway, I'll upload a -7 SRPM with your suggestions tonight. Spec URL: http://bochecha.fedorapeople.org/packages/sil-abyssinica-fonts/sil-abyssinica-fonts.spec SRPM URL: http://bochecha.fedorapeople.org/packages/sil-abyssinica-fonts/sil-abyssinica-fonts-1.0-7.fc12.src.rpm * Thu Feb 11 2010 Mathieu Bridon <bochecha> - 1.0-7 - Use new archive from upstream at same location (which is lowercase now) - Remove dubious Provides: (RHBZ#563395) * Wed Feb 10 2010 Mathieu Bridon <bochecha> - 1.0-6 - Renamed from abyssinica-fonts to sil-abyssinica-fonts Thanks Mathieu! Quick re-review: - rpmlint free of warnings :) - license correct - source md5sum unchanged - currently no font .conf file - follows fonts packaging guidelines Renamed package is APPROVED. New Package CVS Request ======================= Package Name: sil-abyssinica-fonts Short Description: SIL Abyssinica fonts Owners: bochecha Branches: devel InitialCC: CVS done (by process-cvs-requests.py). Package imported into CVS and built for Rawhide. Thanks Jens for the re-review and Kevin for the CVS creation. Please always put the fonts-sig in CC when you're making a cvs request for a fonts package. Since it is not a human user, it's not easy to add later through the web interface (I'll try to ping an admin fo fix this package) I added fonts-sig. (In reply to comment #12) > I added fonts-sig. Add it to the other ACLs as well if you want, I don't mind co-maintainers :) Pseudousers like fonts-sig are just for bug-tracking - they don't currently allow others access. :) |