Bug 565486

Summary:	Review Request: dmz-cursor-themes - X cursors themes
Product:	[Fedora] Fedora	Reporter:	Benjamin Otte <otte>
Component:	Package Review	Assignee:	Matthias Clasen <mclasen>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mclasen, notting
Target Milestone:	---	Flags:	mclasen: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-02-19 21:18:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Benjamin Otte 2010-02-15 13:13:25 UTC

Spec URL: http://people.freedesktop.org/~company/stuff/dmz-cursor-themes.spec
SRPM URL: http://people.freedesktop.org/~company/stuff/dmz-cursor-themes-0.4-1.src.rpm
Description: dmz cursor themes are X cursors themes done by Jakub Steiner and used by OpenSUSE.

Comment 1 Matthias Clasen 2010-02-16 00:00:26 UTC

builds fine in mock

rpmlint output:

rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/dmz-cursor-themes-0.4-1.*.rpm
dmz-cursor-themes.noarch: W: spelling-error %description -l en_US Jakub -> Jake, Jakarta, Jacob
dmz-cursor-themes.src: W: spelling-error %description -l en_US Jakub -> Jake, Jakarta, Jacob
dmz-cursor-themes.src: W: invalid-url Source0: dmz-cursor-themes-e5ce7614.tar.bz2
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

The spelling error is laughable, and the url has a comment explaining it.

Comment 2 Matthias Clasen 2010-02-16 00:47:17 UTC

package name: looks fine to me
spec file name: ok
packaging guidelines: ok
license: ok
license field: ok
license file: ok
spec language: ok
readable: ok
upstream sources: the download instructions don't seem to work. When I go there, I get 'No such tree SHA1 was found'
buildable: ok
ExcludeArch: none, ok
BuildRequires: ok
locales: none, ok
shared libs: none, ok
system libs: none, ok
relocatable: no
directory ownership: ok
duplicate files: ok
file permissions: ok
%clean: ok
macro use: ok
permissible content: ok
large docs: none, ok
%doc content: ok
headers: none, ok
static libs: none, ok
pkgconfig: ok
shared libs: none, ok
devel dependencies: ok
libtool archives: ok
gui app: none, ok
directory ownership: ok
%install: ok
utf8 filenames: ok


summary: fix the download instructions, everything else is looking great

Comment 3 Benjamin Otte 2010-02-16 13:57:47 UTC

Updated with fixes:
Spec URL: http://people.freedesktop.org/~company/stuff/dmz-cursor-themes.spec
SRPM URL:
http://people.freedesktop.org/~company/stuff/dmz-cursor-themes-0.4-2.src.rpm

Comment 4 Matthias Clasen 2010-02-16 19:25:36 UTC

Ok thanks. Download works now. With that, APPROVED

Comment 5 Benjamin Otte 2010-02-18 10:27:02 UTC

New Package CVS Request
=======================
Package Name: dmz-cursor-themes
Short Description: X cursors themes
Owners: company
Branches: F-13
InitialCC:

Comment 6 Jason Tibbitts 2010-02-19 19:47:08 UTC

CVS done (by process-cvs-requests.py).

Comment 7 Benjamin Otte 2010-02-19 21:18:36 UTC

Uploaded to rawhide and F-13.