Bug 565827

Summary: RFE: FailedQE value in Verified field + update logic
Product: [Community] Bugzilla Reporter: Chris Ward <cward>
Component: Bugzilla GeneralAssignee: Noura El hawary <nelhawar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: low    
Version: 3.4CC: jskrabal, sgreen
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
: 567244 (view as bug list) Environment:
Last Closed: 2010-02-17 10:58:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 567244    
Attachments:
Description Flags
v1 code to add FailedQA to cf_verified none

Description Chris Ward 2010-02-16 13:18:10 UTC 
Description of problem:
Recently we dropped the FAILS_QA state as part of the Bugzilla State clean-up. The original request was two part; first part, drop FAILS_QA, has already been completed. Now on to second (optional) part, since it is now being requested.

Summary:
 * add FailedQA value to Verified field (cf_verified) (after PreBeta)
 * include logic:
  * if bug state transitions from ON_QA -> ASSIGNED
   * if cf_verified not contains 'FailedQA', then append 'FailedQA'
   * else continue.

Example; user logs in and transitions bug #000000, which currently has no items selected in the Verified field, from ON_QA state to ASSIGNED state and saves changes. Upon page refresh, bug is in the ASSIGNED state and FailedQA value is selected in verified field.
Comment 1 Noura El hawary 2010-02-17 10:57:24 UTC 
Created attachment 394708 [details]
v1 code to add FailedQA to cf_verified

Already committed the attached patch to svn as it has been approved before from dkl in the bug:

https://bugzilla.redhat.com/show_bug.cgi?id=530345

but took off the private comment. the patch is applied to bz-web1 for your testing, also added FailedQA to cf_verified list of values, so this functionality should be live in the next bugzilla release which will happen this week.

Regards,
Noura
Comment 2 Simon Green 2012-05-25 01:05:32 UTC 
(In reply to comment #0)
> Description of problem:
> Recently we dropped the FAILS_QA state as part of the Bugzilla State
> clean-up. The original request was two part; first part, drop FAILS_QA, has
> already been completed. Now on to second (optional) part, since it is now
> being requested.
> 
> Summary:
>  * add FailedQA value to Verified field (cf_verified) (after PreBeta)
>  * include logic:
>   * if bug state transitions from ON_QA -> ASSIGNED
>    * if cf_verified not contains 'FailedQA', then append 'FailedQA'
>    * else continue.

Just a note on this bug, effective very soon (when 4.2.1-1.5 is released), adding FailedQA to the cf_verified field only only happen if the user making the change can see this value.

Sorry for the regression (and short notice), but as it standard this is a security issue.

  -- simon