Description of problem: Recently we dropped the FAILS_QA state as part of the Bugzilla State clean-up. The original request was two part; first part, drop FAILS_QA, has already been completed. Now on to second (optional) part, since it is now being requested. Summary: * add FailedQA value to Verified field (cf_verified) (after PreBeta) * include logic: * if bug state transitions from ON_QA -> ASSIGNED * if cf_verified not contains 'FailedQA', then append 'FailedQA' * else continue. Example; user logs in and transitions bug #000000, which currently has no items selected in the Verified field, from ON_QA state to ASSIGNED state and saves changes. Upon page refresh, bug is in the ASSIGNED state and FailedQA value is selected in verified field.
Created attachment 394708 [details] v1 code to add FailedQA to cf_verified Already committed the attached patch to svn as it has been approved before from dkl in the bug: https://bugzilla.redhat.com/show_bug.cgi?id=530345 but took off the private comment. the patch is applied to bz-web1 for your testing, also added FailedQA to cf_verified list of values, so this functionality should be live in the next bugzilla release which will happen this week. Regards, Noura
(In reply to comment #0) > Description of problem: > Recently we dropped the FAILS_QA state as part of the Bugzilla State > clean-up. The original request was two part; first part, drop FAILS_QA, has > already been completed. Now on to second (optional) part, since it is now > being requested. > > Summary: > * add FailedQA value to Verified field (cf_verified) (after PreBeta) > * include logic: > * if bug state transitions from ON_QA -> ASSIGNED > * if cf_verified not contains 'FailedQA', then append 'FailedQA' > * else continue. Just a note on this bug, effective very soon (when 4.2.1-1.5 is released), adding FailedQA to the cf_verified field only only happen if the user making the change can see this value. Sorry for the regression (and short notice), but as it standard this is a security issue. -- simon