Bug 565887
| Summary: | LD_LIBRARY_PATH leaks to install.img from compose environment | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | John Reiser <jreiser> |
| Component: | anaconda | Assignee: | Anaconda Maintenance Team <anaconda-maint-list> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | anaconda-maint-list, jonathan, vanmeeuwen+fedora |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | anaconda-13.29-1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-22 19:58:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Thanks for the patch. anaconda-13.29-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/anaconda-13.29-1.fc13 python-urlgrabber-3.9.1-5.fc13,anaconda-13.29-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-urlgrabber-3.9.1-5.fc13,anaconda-13.29-1.fc13 python-urlgrabber-3.9.1-5.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2688 |
Description of problem: get_dso_deps() does not control the environment variable LD_LIBRARY_PATH when tracking down the DSO dependencies of an executable for the install.img. Because of this, the dependencies may be wrong. The runtime environment of install.img has a default LD_LIBRARY_PATH [namely, unset]. In practice the bad result might be only a larger-than-necessary install.img: the false dependency may copy some additional libraries, but the actual install-time dependency may be covered by naming the needed libraries explicitly in KEEPFILES. The bad effects are less unlikely because of the 'chroot' done during the discovery process. However, it is possible that some executable that requires an unusual library may fail to run during install, because a unique DSO found by LD_LIBRARY_PATH at compose time will be put into a directory that is not searched during install. Version-Release number of selected component (if applicable): anaconda-13.26-1.fc13.x86_64 How reproducible: every time Steps to Reproduce: 1. inspect source code 2. 3. Actual results: File buildinstall.fuctions, function get_dso_deps(): $(/usr/sbin/chroot $root env LD_TRACE_PRELINKING=1 LD_WARN= \ LD_TRACE_LOADED_OBJECTS=1 $LDSO $bin) Expected results: $(/usr/sbin/chroot $root env --unset=LD_LIBRARY_PATH \ LD_TRACE_PRELINKING=1 LD_WARN= \ LD_TRACE_LOADED_OBJECTS=1 $LDSO $bin) Additional info: