Bug 565887 - LD_LIBRARY_PATH leaks to install.img from compose environment
Summary: LD_LIBRARY_PATH leaks to install.img from compose environment
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-16 16:13 UTC by John Reiser
Modified: 2010-02-26 02:59 UTC (History)
3 users (show)

Fixed In Version: anaconda-13.29-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-22 19:58:02 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John Reiser 2010-02-16 16:13:43 UTC
Description of problem:  get_dso_deps() does not control the environment variable LD_LIBRARY_PATH when tracking down the DSO dependencies of an executable for the install.img.  Because of this, the dependencies may be wrong.  The runtime environment of install.img has a default LD_LIBRARY_PATH [namely, unset].  In practice the bad result might be only a larger-than-necessary install.img: the false dependency may copy some additional libraries, but the actual install-time dependency may be covered by naming the needed libraries explicitly in KEEPFILES.  The bad effects are less unlikely because of the 'chroot' done during the discovery process.  However, it is possible that some executable that requires an unusual library may fail to run during install, because a unique DSO found by LD_LIBRARY_PATH at compose time will be put into a directory that is not searched during install.


Version-Release number of selected component (if applicable):
anaconda-13.26-1.fc13.x86_64


How reproducible: every time


Steps to Reproduce:
1. inspect source code
2.
3.
  
Actual results: File buildinstall.fuctions, function get_dso_deps():
        $(/usr/sbin/chroot $root env LD_TRACE_PRELINKING=1 LD_WARN= \
                                     LD_TRACE_LOADED_OBJECTS=1 $LDSO $bin)


Expected results:
        $(/usr/sbin/chroot $root env --unset=LD_LIBRARY_PATH \
                                     LD_TRACE_PRELINKING=1 LD_WARN= \
                                     LD_TRACE_LOADED_OBJECTS=1 $LDSO $bin)


Additional info:

Comment 1 Chris Lumens 2010-02-22 19:58:02 UTC
Thanks for the patch.

Comment 2 Fedora Update System 2010-02-23 03:42:35 UTC
anaconda-13.29-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/anaconda-13.29-1.fc13

Comment 3 Fedora Update System 2010-02-23 14:04:52 UTC
python-urlgrabber-3.9.1-5.fc13,anaconda-13.29-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-urlgrabber-3.9.1-5.fc13,anaconda-13.29-1.fc13

Comment 4 Fedora Update System 2010-02-26 02:59:16 UTC
python-urlgrabber-3.9.1-5.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/F13/FEDORA-2010-2688


Note You need to log in before you can comment on or make changes to this bug.