Bug 566379
| Summary: | Review Request: perl-Ham-Reference-QRZ - Ham::Reference::QRZ perl modul | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jens Maucher <jensm.fedora> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | christoph.wickert, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-01 18:50:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jens Maucher
2010-02-18 09:18:33 UTC
Some notes:
* License
- For this package the license tag should be "GPL+ or Artistic".
ref:
https://fedoraproject.org/wiki/Packaging/Perl#License_tag
* Summary
- Please improve Summary (please check the description in
"abstract:" item of META.yml file)
* URL
- We usually use http://search.cpan.org/dist/<module name> .
For this package, it is http://search.cpan.org/dist/Ham-Reference-QRZ/
* SourceURL
- Recent spec file generated by cpanspec seems to use
http://www.cpan.org/modules/by-module/Ham/Ham-Reference-QRZ-%{version}.tar.gz
* BuildArch
- This package should create noarch binary rpm ("BuildArch: noarch" is needed)
* Requires
- Usually dependencies related to perl module based rpms are
automatically detected by rpmbuild itself.
For this package, "Requires: perl(LWP::UserAgent)" is automatically
added by rpmbuild and is not needed to be written explicitly.
- Please check the following URL:
https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires
perl(XML::Simple) as a dependency is also available as rpm in the database, so it is automatically added. perl(XML::Simple) is also not needed in %Requires? Ham::Reference::QRZ 0.02 is only available in http://www.cpan.org/modules/by-module/Ham/BRADMC/ The older version (0.01) is available under the link you posted in #1 Spec URL: see above SRPM URL: http://jensm.fedorapeople.org/perl-Ham-Reference-QRZ-0.02-2.fc13.src.rpm Koji build:http://koji.fedoraproject.org/koji/taskinfo?taskID=2006564 Edit: SRPM URL: http://jensm.fedorapeople.org/perl-Ham-Reference-QRZ-0.02-2.fc12.src.rpm I hate it, it would be cool if it were possible editing the own posts. -.- For -2:
* Module compat Requires for perl modules
- You don't seem to have addressed:
https://fedoraproject.org/wiki/Packaging/Perl#Versioned_MODULE_COMPAT__Requires
Please add MODULE_COMPAT Requires
* BuildRequires for tests
- build.log shows:
--------------------------------------------------------
82 t/00-load.t ....... ok
83 t/pod-coverage.t .. skipped: Test::Pod::Coverage 1.08 required for testing POD coverage
84 t/pod.t ........... skipped: Test::Pod 1.22 required for testing POD
--------------------------------------------------------
Please add "perl(Test::Pod::Coverage)" "perl(Test::Pod)" to
BuildRequires to enable the latter 2 tests.
Ok, i uploaded the new spec (link above) and a new SRPM http://jensm.fedorapeople.org/perl-Ham-Reference-QRZ-0.02-3.fc12.src.rpm ----------------------------------------------------------------- This package (perl-Ham-Reference-QRZ) is APPROVED by mtasaka ----------------------------------------------------------------- New Package CVS Request ======================= Package Name: perl-Ham-Reference-QRZ Short Description: An object oriented front end for the QRZ.COM Amateur Radio call-sign database Owners: jensm Branches: F-12 F-13 CVS done (by process-cvs-requests.py). Closing. |