Bug 566397
| Summary: | Review Request: osso-gwobex - Obex helper library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mclasen, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-01 17:09:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Bastien Nocera
2010-02-18 11:12:55 UTC
Builds fine in mock. rpmlint results: [mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/osso-gwobex-0.64-1.bef6bc21.fc13.x86_64.rpm osso-gwobex.x86_64: W: spelling-error Summary(en_US) Obex -> Ibex, Ob ex, Ob-ex osso-gwobex.x86_64: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Glob osso-gwobex.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git osso-gwobex.x86_64: W: one-line-command-in-%post ldconfig osso-gwobex.x86_64: W: one-line-command-in-%postun ldconfig 1 packages and 0 specfiles checked; 0 errors, 5 warnings. [mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm osso-gwobex.src: W: spelling-error Summary(en_US) Obex -> Ibex, Ob ex, Ob-ex osso-gwobex.src: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Glob osso-gwobex.src: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git osso-gwobex.src: W: invalid-url Source0: maemo-bluetooth-osso-gwobex-bef6bc21.tar.gz osso-gwobex.x86_64: W: spelling-error Summary(en_US) Obex -> Ibex, Ob ex, Ob-ex osso-gwobex.x86_64: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Glob osso-gwobex.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git osso-gwobex.x86_64: W: one-line-command-in-%post ldconfig osso-gwobex.x86_64: W: one-line-command-in-%postun ldconfig osso-gwobex-debuginfo.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git osso-gwobex-devel.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git 4 packages and 0 specfiles checked; 0 errors, 11 warnings. All the spelling warnings are laughable, the one-line-command ones are not significant. As for the invalid-url ones, it would perhaps be good to add a comment to the source url explaining that one has to try repeatedly, since the tarball is generated on-the-fly. package name: ok spec file name: ok packaging guidelines: ok, could use -p for %post, %postun license: ok license field: the few source files I checked were explicit about version 2.1, so it should probably be LGPLv2 license file: ok spec language: ok spec readable: ok buildable: yep ExcludeArch: ok BuildRequires: ok locales: ok ldconfig: ok relocatable: ok directory ownership: ok duplicate files: ok permissions: ok %clean: ok macros: ok permissible content: yep large docs: ok %doc content: ok headers: ok static libs: ok pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok duplicate ownership: ok %install: ok utf8 filenames: ok Summary: - add a comment about tarball generation - clarify license field All fixed: http://people.fedoraproject.org/~hadess/osso-gwobex/osso-gwobex-0.64-2.bef6bc21.fc12.src.rpm http://people.fedoraproject.org/~hadess/osso-gwobex/osso-gwobex.spec Looks good now. APPROVED New Package CVS Request ======================= Package Name: osso-gwobex Short Description: Obex helper library Owners: hadess Branches: F-12 InitialCC: CVS done (by process-cvs-requests.py). Added an F-13 branch as well. Built in F12, F13 and devel. |