Bug 566397 - Review Request: osso-gwobex - Obex helper library
Summary: Review Request: osso-gwobex - Obex helper library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-02-18 11:12 UTC by Bastien Nocera
Modified: 2010-03-01 17:09 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-01 17:09:18 UTC
Type: ---
Embargoed:
mclasen: fedora-review+
j: fedora-cvs+


Attachments (Terms of Use)

Description Bastien Nocera 2010-02-18 11:12:55 UTC
Spec URL: http://people.fedoraproject.org/~hadess/osso-gwobex/osso-gwobex.spec
SRPM URL: http://people.fedoraproject.org/~hadess/osso-gwobex/osso-gwobex-0.64-1.bef6bc21.fc12.src.rpm
Description: osso-gwobex contains a GLib helper library for ObexFTP and 
ObexPush access.

Comment 1 Matthias Clasen 2010-02-18 15:07:02 UTC
Builds fine in mock.

rpmlint results:

[mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/osso-gwobex-0.64-1.bef6bc21.fc13.x86_64.rpm 
osso-gwobex.x86_64: W: spelling-error Summary(en_US) Obex -> Ibex, Ob ex, Ob-ex
osso-gwobex.x86_64: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Glob
osso-gwobex.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git
osso-gwobex.x86_64: W: one-line-command-in-%post ldconfig
osso-gwobex.x86_64: W: one-line-command-in-%postun ldconfig
1 packages and 0 specfiles checked; 0 errors, 5 warnings.
[mclasen@planemask Desktop]$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
osso-gwobex.src: W: spelling-error Summary(en_US) Obex -> Ibex, Ob ex, Ob-ex
osso-gwobex.src: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Glob
osso-gwobex.src: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git
osso-gwobex.src: W: invalid-url Source0: maemo-bluetooth-osso-gwobex-bef6bc21.tar.gz
osso-gwobex.x86_64: W: spelling-error Summary(en_US) Obex -> Ibex, Ob ex, Ob-ex
osso-gwobex.x86_64: W: spelling-error %description -l en_US GLib -> G Lib, Glib, Glob
osso-gwobex.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git
osso-gwobex.x86_64: W: one-line-command-in-%post ldconfig
osso-gwobex.x86_64: W: one-line-command-in-%postun ldconfig
osso-gwobex-debuginfo.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git
osso-gwobex-devel.x86_64: W: invalid-url URL git://gitorious.org/maemo-bluetooth/osso-gwobex.git
4 packages and 0 specfiles checked; 0 errors, 11 warnings.


All the spelling warnings are laughable, the one-line-command ones are not significant. As for the invalid-url ones, it would perhaps be good to add a comment to the source url explaining that one has to try repeatedly, since the tarball is generated on-the-fly.

Comment 2 Matthias Clasen 2010-02-18 16:01:06 UTC
package name: ok
spec file name: ok
packaging guidelines: ok, could use -p for %post, %postun
license: ok
license field: the few source files I checked were explicit about version 2.1, so it should probably be LGPLv2
license file: ok
spec language: ok
spec readable: ok
buildable: yep
ExcludeArch: ok
BuildRequires: ok
locales: ok
ldconfig: ok
relocatable: ok
directory ownership: ok
duplicate files: ok
permissions: ok
%clean: ok
macros: ok
permissible content: yep
large docs: ok
%doc content: ok
headers: ok
static libs: ok
pc files: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
duplicate ownership: ok
%install: ok
utf8 filenames: ok

Summary: 
 - add a comment about tarball generation
 - clarify license field

Comment 4 Matthias Clasen 2010-02-18 16:14:33 UTC
Looks good now. APPROVED

Comment 5 Bastien Nocera 2010-02-18 16:20:14 UTC
New Package CVS Request
=======================
Package Name: osso-gwobex
Short Description: Obex helper library
Owners: hadess
Branches: F-12
InitialCC:

Comment 6 Jason Tibbitts 2010-02-19 20:09:44 UTC
CVS done (by process-cvs-requests.py).

Added an F-13 branch as well.

Comment 7 Bastien Nocera 2010-03-01 17:09:18 UTC
Built in F12, F13 and devel.


Note You need to log in before you can comment on or make changes to this bug.