Bug 567110
| Summary: | Review Request: libucil - Library to render text and graphic overlays onto video images | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Thomas Janssen <thomasj> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | dominik, fedora-package-review, kdudka, notting, thomasj |
| Target Milestone: | --- | Flags: | thomasj:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libucil-0.9.8-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-26 19:47:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 567109 | ||
| Bug Blocks: | 567111 | ||
|
Description
Robert Scheck
2010-02-21 17:34:07 UTC
Ok, this is a re-review request due to upstream name change.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
XX - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
be48e766945a9a54bdf50fc0bbe39200 libucil-0.9.8.tar.gz
NN - Package needs ExcludeArch
OK - BuildRequires correct
NN - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
NN - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.
OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.
NN - Package is a GUI app and has a .desktop file
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - final provides and requires are sane:
Issues:
License included in the tar says GPLv3+ But the source says GPLv2+. Would be nice to know what upstream really want. Though i cant find anything that says it's considered a blocker.
I have checked for obsoletes and provides. I had a chat in IRC with the
maintainer and this seems to be the sane way.
APPROVED
Thank you for reviewing the package. New Package CVS Request ======================= Package Name: libucil Short Description: Library to render text and graphic overlays onto video images Owners: robert Branches: EL-5 F-11 F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). libucil-0.9.8-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.fc13 libucil-0.9.8-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.el5 libucil-0.9.8-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.fc12 libucil-0.9.8-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libucil-0.9.8-1.fc11 libucil-0.9.8-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. libucil-0.9.8-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. libucil-0.9.8-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. libucil-0.9.8-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |