Bug 567135

Summary: gpk-update-viewer displays poor error dialog
Product: [Fedora] Fedora Reporter: Chris Tyler <ctyler.fedora>
Component: gnome-packagekitAssignee: Richard Hughes <richard>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 12CC: rhughes, richard
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-23 10:13:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Cannot cancel running task: Cancel or Quit? none

Description Chris Tyler 2010-02-21 20:33:44 UTC
Created attachment 395388 [details]
Cannot cancel running task: Cancel or Quit?

Description of problem:
- gpk-update-viewer sometimes presents a cancel dialog that is incomprehensible.

Version-Release number of selected component (if applicable):
- gnome-packaqekit-2.28.3-0.1.20091211git.fc12.i686

How reproducible:
- Click on window manager's close button while gpk-update-viewer is updating - some of this time an error dialog is display (other times the window closes without any message).
  
Actual results:
- Text of the error dialog reads "<b>Cannot cancel running task.</b><br />There are tasks that cannot be cancelled." -- however, the two buttons on that dialog are labeled "Cancel" (?!) and "Quit" (?!).
- This makes no sense because the user did not specify that an operation should be cancelled, and if cancelling is truly impossible, then neither of the buttons should be pressed.

Expected results:
- No error dialog should be presented -- the update should continue in the background as it would if you started it with "pkcon update --nowait"
- If an error dialog is presented, it should included button labels that make some sense.

Comment 1 Richard Hughes 2010-03-23 10:13:39 UTC
We've fixed this crazy dialog in F13. Thanks.