Bug 570111
| Summary: | Review Request: rubygem-right_http_connection - RightScale's HTTP/S module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Fojtik <mfojtik> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, lkundrak, mfojtik, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | noarch | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-right_http_connection-1.2.4-2.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-24 17:59:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 570457 | ||
| Bug Blocks: | 570113 | ||
|
Description
Michal Fojtik
2010-03-03 10:51:04 UTC
Taking this. 1.) Duplicate %files entries warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/History.txt warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/Manifest.txt warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/README.txt 2.) Dependency on ruby(abi) = 1.8 missing 3.) Use %global instead of %define wherever it makes sense 4.) Seems to me like your package name is wrong:
# Packages that contain Ruby Gems must be called rubygem-%{gemname} where gemname is the name from the Gem's specification. [1]
[1] http://fedoraproject.org/wiki/Packaging/Ruby
You turned _s into -s; I doubt there's a reason to do that. There indeed are ruby gems with _ in package name: http://koji.fedoraproject.org/koji/search?match=glob&type=package&terms=ruby*_*
* License ok, text included in source files * Spec file clean, legible, american english * Builds fine in mock (In reply to comment #3) > 4.) Seems to me like your package name is wrong: > > # Packages that contain Ruby Gems must be called rubygem-%{gemname} where > gemname is the name from the Gem's specification. [1] > [1] http://fedoraproject.org/wiki/Packaging/Ruby > > You turned _s into -s; I doubt there's a reason to do that. There indeed are > ruby gems with _ in package name: > http://koji.fedoraproject.org/koji/search?match=glob&type=package&terms=ruby*_* (In reply to comment #2) > 1.) Duplicate %files entries > > warning: File listed twice: > /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/History.txt > warning: File listed twice: > /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/Manifest.txt > warning: File listed twice: > /usr/lib/ruby/gems/1.8/gems/right_http_connection-1.2.4/README.txt FIXED. > > 2.) Dependency on ruby(abi) = 1.8 missing FIXED. > > 3.) Use %global instead of %define wherever it makes sense FIXED. (Alway forgot this. Need to write patch for gem2rpm ;) Spec URL: http://mifo.sk/rubygem-right_http_connection.spec SRPM URL: http://mifo.sk/rubygem-right_http_connection-1.2.4-2.fc12.src.rpm * Correctly named * Version correct * Filelist sane * Requires/provides ok * Macros used consistently APROVED New Package CVS Request ======================= Package Name: rubygem-right_http_connection RightScale's robust HTTP/S connection module. Owners: mfojtik Branches: F-11 F-12 F-13 EL-5 This CVS request is rather odd; it looks like the description ended up on the wrong line. Please fix and re-set the fedora-cvs flag. New Package CVS Request ======================= Package Name: rubygem-right_http_connection Short Description: RightScale's robust HTTP connection module. Owners: mfojtik Branches: devel F-11 F-12 F-13 EL-5 CVS done (by process-cvs-requests.py). rubygem-right_http_connection-1.2.4-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.fc11 rubygem-right_http_connection-1.2.4-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.fc12 rubygem-right_http_connection-1.2.4-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.fc13 rubygem-right_aws-1.10.0-3.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-right_aws-1.10.0-3.fc11 rubygem-right_http_connection-1.2.4-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.el5 rubygem-right_http_connection-1.2.4-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-right_http_connection'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.el5 rubygem-right_http_connection-1.2.4-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-right_http_connection'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.fc12 rubygem-right_http_connection-1.2.4-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-right_http_connection'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.fc13 rubygem-right_http_connection-1.2.4-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-right_http_connection'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-right_http_connection-1.2.4-2.fc11 rubygem-right_aws-1.10.0-3.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-right_aws'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rubygem-right_aws-1.10.0-3.fc11 rubygem-right_http_connection-1.2.4-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. rubygem-right_http_connection-1.2.4-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. rubygem-right_http_connection-1.2.4-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. rubygem-right_http_connection-1.2.4-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |