Bug 573119
| Summary: | nagios 3.2.0-4: the init script is broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> | ||||
| Component: | nagios | Assignee: | Peter Lemenkov <lemenkov> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | bugzilla-2004, lemenkov, pbrobinson, redhat, sebastian.gosenheimer, wtogami | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | nagios-3.2.1-1.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-03-23 01:55:25 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 572587 | ||||||
| Attachments: |
|
||||||
|
Description
Jose Pedro Oliveira
2010-03-12 21:31:45 UTC
Missing space in nagios-0002-SELinux-relabeling.patch:
< + [-x /sbin/restorecon ] && /sbin/restorecon $NagiosRunFile
---
> + [ -x /sbin/restorecon ] && /sbin/restorecon $NagiosRunFile
Peter, I decreased the nagios-3.2.0-4 RPMS karma in Bodhi (F-11, F-12, F13). Rawhide as usually gets pushed. There is also a small "annoyance" in the patch patch nagios-0001-from-rpm.patch: the lines added by this patch are padded with spaces and the rest of the init script uses tabs. /jpo Created attachment 399780 [details]
Patch to the patches
Replaces indenting spaces by tabs in "nagios-0001-from-rpm.patch" and corrects the problem in "nagios-0002-SELinux-relabeling.patch".
nagios-3.2.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc12 nagios-3.2.1-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc11 nagios-3.2.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc13 Peter, Any chance of correcting the indentation problems caused by the first patch - nagios-0001-from-rpm.patch ? See second part of comment #c2 and patch in #c3. /jpo (In reply to comment #7) > Peter, > > Any chance of correcting the indentation problems caused by the first patch - > nagios-0001-from-rpm.patch ? > > See second part of comment #c2 and patch in #c3. Oops, I missed this comment. Well, it's not a highest priority issue, so I'd rather push these packages as is. I'll reident this patch later. Please, open another one ticket for that (just to be sure, that I won't forget about it). (In reply to comment #8) > (In reply to comment #7) > > Peter, > > > > Any chance of correcting the indentation problems caused by the first patch - > > nagios-0001-from-rpm.patch ? > > > > See second part of comment #c2 and patch in #c3. > > Oops, I missed this comment. Well, it's not a highest priority issue, so I'd > rather push these packages as is. I'll reident this patch later. Please, open > another one ticket for that (just to be sure, that I won't forget about it). Or you could solve this by releasing nagios-3.2.1-2 only for rawhide ;) nagios-3.2.1-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nagios'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc13 nagios-3.2.1-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nagios'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc12 nagios-3.2.1-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update nagios'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc11 *** Bug 574896 has been marked as a duplicate of this bug. *** nagios-3.2.1-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. nagios-3.2.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. nagios-3.2.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |