Bug 573119 - nagios 3.2.0-4: the init script is broken
Summary: nagios 3.2.0-4: the init script is broken
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: nagios
Version: rawhide
Hardware: All
OS: Linux
low
high
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 574896 (view as bug list)
Depends On:
Blocks: 572587
TreeView+ depends on / blocked
 
Reported: 2010-03-12 21:31 UTC by Jose Pedro Oliveira
Modified: 2010-03-23 02:21 UTC (History)
6 users (show)

Fixed In Version: nagios-3.2.1-1.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-03-23 01:55:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Patch to the patches (1.97 KB, patch)
2010-03-12 23:02 UTC, Jose Pedro Oliveira
no flags Details | Diff

Description Jose Pedro Oliveira 2010-03-12 21:31:45 UTC
Description of problem:
Starting nagios:/etc/init.d/nagios: line 134: [-x: command not found

The culprit is the SELinux relabeling patch (there is a space missing).

Version-Release number of selected component (if applicable):
nagios-3.2.0-4 (updates testing for F11, F12, ...)


How reproducible:
Always


Steps to Reproduce:
Stop and start the daemon.
  
Actual results:
Starting nagios:/etc/init.d/nagios: line 134: [-x: command not found

Comment 1 Jose Pedro Oliveira 2010-03-12 21:33:54 UTC
Missing space in nagios-0002-SELinux-relabeling.patch:

< +   [-x /sbin/restorecon ] && /sbin/restorecon $NagiosRunFile
---
> +   [ -x /sbin/restorecon ] && /sbin/restorecon $NagiosRunFile

Comment 2 Jose Pedro Oliveira 2010-03-12 21:40:05 UTC
Peter,

I decreased the nagios-3.2.0-4 RPMS karma in Bodhi (F-11, F-12, F13). Rawhide as usually gets pushed.

There is also a small "annoyance" in the patch patch nagios-0001-from-rpm.patch:
the lines added by this patch are padded with spaces and the rest of the init script uses tabs.


/jpo

Comment 3 Jose Pedro Oliveira 2010-03-12 23:02:19 UTC
Created attachment 399780 [details]
Patch to the patches

Replaces indenting spaces by tabs in "nagios-0001-from-rpm.patch" and corrects the problem in "nagios-0002-SELinux-relabeling.patch".

Comment 4 Fedora Update System 2010-03-13 07:00:27 UTC
nagios-3.2.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc12

Comment 5 Fedora Update System 2010-03-13 07:00:36 UTC
nagios-3.2.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc11

Comment 6 Fedora Update System 2010-03-13 07:00:45 UTC
nagios-3.2.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc13

Comment 7 Jose Pedro Oliveira 2010-03-13 18:08:44 UTC
Peter,

Any chance of correcting the indentation problems caused by the first patch - nagios-0001-from-rpm.patch ?

See second part of comment #c2 and patch in #c3.

/jpo

Comment 8 Peter Lemenkov 2010-03-13 18:34:53 UTC
(In reply to comment #7)
> Peter,
> 
> Any chance of correcting the indentation problems caused by the first patch -
> nagios-0001-from-rpm.patch ?
> 
> See second part of comment #c2 and patch in #c3.

Oops, I missed this comment. Well, it's not a highest priority issue, so I'd rather push these packages as is. I'll reident this patch later. Please, open another one ticket for that (just to be sure, that I won't forget about it).

Comment 9 Jose Pedro Oliveira 2010-03-13 19:02:22 UTC
(In reply to comment #8)
> (In reply to comment #7)
> > Peter,
> > 
> > Any chance of correcting the indentation problems caused by the first patch -
> > nagios-0001-from-rpm.patch ?
> > 
> > See second part of comment #c2 and patch in #c3.
> 
> Oops, I missed this comment. Well, it's not a highest priority issue, so I'd
> rather push these packages as is. I'll reident this patch later. Please, open
> another one ticket for that (just to be sure, that I won't forget about it).    

Or you could solve this by releasing nagios-3.2.1-2 only for rawhide ;)

Comment 10 Fedora Update System 2010-03-14 13:41:37 UTC
nagios-3.2.1-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nagios'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc13

Comment 11 Fedora Update System 2010-03-16 00:43:06 UTC
nagios-3.2.1-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nagios'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc12

Comment 12 Fedora Update System 2010-03-16 00:49:10 UTC
nagios-3.2.1-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update nagios'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/nagios-3.2.1-1.fc11

Comment 13 Peter Lemenkov 2010-03-18 19:24:55 UTC
*** Bug 574896 has been marked as a duplicate of this bug. ***

Comment 14 Fedora Update System 2010-03-23 01:55:16 UTC
nagios-3.2.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 15 Fedora Update System 2010-03-23 02:09:16 UTC
nagios-3.2.1-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2010-03-23 02:21:28 UTC
nagios-3.2.1-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.