Bug 573264
| Summary: | Review Request: qt-assistant-adp - Compatibility version of Qt Assistant | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kevin Kofler <kevin> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-04-21 17:22:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kevin Kofler
2010-03-13 20:15:19 UTC
1. avoiding Conflicts
Since this is targeted for qt-4.7.0 anyway, we can possibly skip the Conflicts, and do something like this instead:
BuildRequires: qt4-devel >= 4.7.0
Requires qt4%{?_isa} >= %{_qt4_version}
I won't consider this a review blocker, but let's do our best to resolve the issue prior to releasing any builds.
Naming: ok
scriplets: ok
licensing: ok
macros: ok
no .desktop file: documented justification for exception, ok.
Otherwise, fairly simple and clean.
APPROVED.
The Conflicts are all versioned so as not to conflict with the current version. I don't see where the problem is there. It's quite a common idiom to have that kind of versioned Conflicts and we're also using it in other places in KDE. AIUI, the spirit of the guidelines is to avoid Conflicts between the current versions of packages. True, still, having a qt4 runtime dependency is largely required anyway, and by adding it, removes the need for conflicts in the first place. New Package CVS Request ======================= Package Name: qt-assistant-adp Short Description: Compatibility version of Qt Assistant Owners: kkofler than rdieter ltinkl Branches: InitialCC: tuxbrewr At this time, we only need this in devel. CVS done (by process-cvs-requests.py). imported/built for rawhide awhile back. Package Change Request ====================== Package Name: qt-assistant-adp New Branches: F-13 Owners: kkofler than rdieter ltinkl thomasj InitialCC: tuxbrewr Package Change Request ====================== Package Name: qt-assistant-adp New Branches: f13 Owners: kkofler than rdieter ltinkl thomasj InitialCC: tuxbrewr Fixed the branch name. Git done (by process-git-requests). |