Spec URL: http://repo.calcforge.org/f14/qt-assistant-adp.spec SRPM URL: http://apt.kde-redhat.org/apt/kde-redhat/SRPMS.kde/unstable/qt-assistant-adp-4.6.2-1.src.rpm (152.7 MiB) Description: The old version of Qt Assistant, based on Assistant Document Profile (.adp) files, and the associated QtAssistantClient library, for compatibility with applications providing help in that format. New applications should use the new version of Qt Assistant introduced in Qt 4.4, based on the Qt Help Framework also introduced in Qt 4.4, instead. This is built from the Qt 4.6.2 tarball (thus the huge SRPM), as Qt 4.7 no longer includes this deprecated library/class/tool.
1. avoiding Conflicts Since this is targeted for qt-4.7.0 anyway, we can possibly skip the Conflicts, and do something like this instead: BuildRequires: qt4-devel >= 4.7.0 Requires qt4%{?_isa} >= %{_qt4_version} I won't consider this a review blocker, but let's do our best to resolve the issue prior to releasing any builds. Naming: ok scriplets: ok licensing: ok macros: ok no .desktop file: documented justification for exception, ok. Otherwise, fairly simple and clean. APPROVED.
The Conflicts are all versioned so as not to conflict with the current version. I don't see where the problem is there. It's quite a common idiom to have that kind of versioned Conflicts and we're also using it in other places in KDE. AIUI, the spirit of the guidelines is to avoid Conflicts between the current versions of packages.
True, still, having a qt4 runtime dependency is largely required anyway, and by adding it, removes the need for conflicts in the first place.
New Package CVS Request ======================= Package Name: qt-assistant-adp Short Description: Compatibility version of Qt Assistant Owners: kkofler than rdieter ltinkl Branches: InitialCC: tuxbrewr At this time, we only need this in devel.
CVS done (by process-cvs-requests.py).
imported/built for rawhide awhile back.
Package Change Request ====================== Package Name: qt-assistant-adp New Branches: F-13 Owners: kkofler than rdieter ltinkl thomasj InitialCC: tuxbrewr
Package Change Request ====================== Package Name: qt-assistant-adp New Branches: f13 Owners: kkofler than rdieter ltinkl thomasj InitialCC: tuxbrewr Fixed the branch name.
Git done (by process-git-requests).