Bug 573721
Summary: | Review Request: javacc-maven-plugin - JavaCC Maven Plugin | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Alexander Kurtakov <akurtako> |
Component: | Package Review | Assignee: | Mary Ellen Foster <mefoster> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, lemenkov, mefoster, notting |
Target Milestone: | --- | Flags: | mefoster:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-03-23 20:26:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Alexander Kurtakov
2010-03-15 16:27:40 UTC
(Assigning it to myself so I don't forget ...) *-javadoc must require jpackage-utils ( %{_javadocdir} owner) Review: OK: rpmlint must be run on every package. Output: javacc-maven-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/javacc-maven-plugin javacc-maven-plugin.src: W: invalid-url Source0: javacc-maven-plugin-2.6.tar.bz2 3 packages and 0 specfiles checked; 0 errors, 2 warnings. False positives OK: The package must be named according to the Package Naming Guidelines . OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. OK: The package must meet the Packaging Guidelines . OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . OK: The License field in the package spec file must match the actual license. OK: The spec file must be written in American English. OK: The spec file for the package MUST be legible. OK: The sources used to build the package must match the upstream source, as provided in the spec URL. OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. OK: All build dependencies must be listed in BuildRequires OK: Packages must NOT bundle copies of system libraries. OK: A package must own all directories that it creates. OK: A Fedora package must not list a file more than once in the spec file's %files listings. OK: Permissions on files must be set properly. OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). OK: Each package must consistently use macros. OK: The package must contain code, or permissable content. OK: Packages must not own files or directories already owned by other packages. OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} OK: All filenames in rpm packages must be valid UTF-8. In addition to the issue mentioned in comment #2, the main package should also Require(post), Require(postun), and just generally Require jpackage-utils (the first two for %update_maven_depmap, the last for directory ownership) Other than that, looks good. (In reply to comment #3) > In addition to the issue mentioned in comment #2, the main package should also > Require(post), Require(postun), and just generally Require jpackage-utils (the > first two for %update_maven_depmap, the last for directory ownership) > All fixed. New sources: Spec URL: http://akurtakov.fedorapeople.org/javacc-maven-plugin.spec SRPM URL: http://akurtakov.fedorapeople.org/javacc-maven-plugin-2.6-2.fc12.src.rpm Looks good to me now -- APPROVED New Package CVS Request ======================= Package Name: javacc-maven-plugin Short Description: JavaCC Maven Plugin Owners: Branches: F-13 InitialCC: There's no owner set? (I assume it's going to be you, but our script doesn't grok that). Can you update and reset the flag when you are ready? New Package CVS Request ======================= Package Name: javacc-maven-plugin Short Description: JavaCC Maven Plugin Owners: akurtakov Branches: F-13 InitialCC: CVS done (by process-cvs-requests.py). Built inrawhide. |