Bug 575085
| Summary: | Review Request: rsvndump - Remote Subversion repository dumping tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Kalev Lember <kalevlember> |
| Component: | Package Review | Assignee: | Terje Røsten <terje.rosten> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, terje.rosten |
| Target Milestone: | --- | Flags: | terje.rosten:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | rsvndump-0.5.3-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-30 02:26:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kalev Lember
2010-03-19 12:12:59 UTC
Looks good, maybe add a Requires: subversion >= 1.4 (see README)?. (In reply to comment #1) > Looks good, maybe add a Requires: subversion >= 1.4 (see README)?. I don't think it's necessary. 1.4 is a rather old version of subversion, and it is present even in RHEL 5. All current Fedora versions have at least subversion 1.6.6, so we shouldn't really care (and add explicit requires) for anything older. There's even a Fedora guideline against explicit library requires (subversion is a library here): https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires However, F-11 ships with asciidoc-8.2.5, but needed is at least 8.4. I'm thinking of not building rsvndump for F-11 at all, as it will be EOL soon anyway. What do you think, should I add BuildRequires: asciidoc >= 1.4 to guard against users who might want to rebuild it themselves on F-11? ok rpmlint
ok naming
ok spec
ok license
ok license tag
ok perms, owns and dirs
ok buildflags
ok sha1sum
3704f8bf3dacace95b91d344b38c8026c0aa29fd rsvndump-0.5.3.tar.bz2
3704f8bf3dacace95b91d344b38c8026c0aa29fd rsvndump-0.5.3.tar.bz2.spec
ok koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=2065270
No issues here: The package rsvndump is APPROVED. Thanks for the review, Terje! New Package CVS Request ======================= Package Name: rsvndump Short Description: Remote Subversion repository dumping tool Owners: kalev Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). rsvndump-0.5.3-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc12 rsvndump-0.5.3-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc13 rsvndump-0.5.3-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rsvndump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc12 rsvndump-0.5.3-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rsvndump'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/rsvndump-0.5.3-1.fc13 rsvndump-0.5.3-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rsvndump-0.5.3-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |