Bug 576758 (moovida-plugins-bad)
| Summary: | Review Request: moovida-plugins-bad - Media Center | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Graeme Gillies <ggillies> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | alex, fedora-package-review, hdegoede, notting |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | hdegoede:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | moovida-plugins-bad-1.0.9-3.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-09-30 06:08:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 554243 | ||
| Bug Blocks: | |||
|
Description
Graeme Gillies
2010-03-25 03:49:31 UTC
Closing this as the master moovida package review bug 554243 has been marked as a dead review. Graeme, I would love to see mooodiva in Fedora, so if you're still interested in packaging up moovida and getting this into Fedora, feel free to re-open. And I'll try to help you sort out any technical issues and sponsor you. Regards, Hans Hi, I have fixed a couple of outstanding issues with this package including changing the %excludes to be removed during %install instead, and getting rid of the duplicate file errors, and now have new packages for review moovida-plugins-bad.spec http://ggillies.fedorapeople.org/moovida-plugins-bad.spec moovida-plugins-bad-1.0.9-3.fc13.src.rpm http://ggillies.fedorapeople.org/moovida-plugins-bad-1.0.9-3.fc13.src.rpm As I offered in the -bad and -good plugins reviews I'll review this and when that is done sponsor you. I hope to finish reviewing at least the base package today before my short vacation. Hi, Sorry for the long delay. I recently switched teams with in Red Hat and as such have been overwhelmed with work a bit. Here is a full review of this package: Full review: Good: - rpmlint checks return: moovida-plugins-bad.src: W: invalid-url Source0: http://www.moovida.com/media/public/moovida-plugins-bad-1.0.9.tar.gz HTTP Error 403: Forbidden moovida-plugins-bad.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Well the one of the 403 error is not so good, so below - package meets naming guidelines - package meets packaging guidelines - license (GPLv3) OK, text not %doc, but also not in upstream tarbal, so no problem, matches source - spec file legible, in am. english - source matches upstream Could not check, as the upstream url is giving 403 errors? I double checked the url and it is the one from upstreams download page. So I wilol just assume this is a temporary glitch and believe the tarbal in the srpm is the correct one. - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime Approved! Hi Graeme, What is your FAS account name? Once I have that I'll add you to the packagers group and sponsor you, then you can do the request for creating a git repo for the moovida package, import, build, etc. Regards. Hans Hi Hans, Thanks for finishing the reviews! I had a look at the url giving 403 errors and it seems that only the moovida-plugins-bad-1.0.9.tar.gz link isn't working. The page with them all is at http://www.moovida.com/download/moovidaclassic/ My FAS account name is ggillies Regards, Graeme Hi, (In reply to comment #6) > My FAS account name is ggillies You've been added to packagers and sponsored :) Regards, Hans New Package SCM Request ======================= Package Name: moovida-plugins-bad Short Description: This package contains plug-ins that have licensing issues, aren't tested well enough, or the code is not of good enough quality for the Moovida media centre Owners: ggillies Branches: f13 f14 InitialCC: Git done (by process-git-requests). moovida-plugins-bad-1.0.9-3.fc14,moovida-plugins-good-1.0.9-3.fc14,moovida-1.0.9-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/moovida-plugins-bad-1.0.9-3.fc14,moovida-plugins-good-1.0.9-3.fc14,moovida-1.0.9-3.fc14 moovida-plugins-bad-1.0.9-3.fc13,moovida-plugins-good-1.0.9-3.fc13,moovida-1.0.9-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/moovida-plugins-bad-1.0.9-3.fc13,moovida-plugins-good-1.0.9-3.fc13,moovida-1.0.9-3.fc13 moovida-plugins-bad-1.0.9-3.fc14, moovida-plugins-good-1.0.9-3.fc14, moovida-1.0.9-3.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update moovida-plugins-bad moovida-plugins-good moovida'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/moovida-plugins-bad-1.0.9-3.fc14,moovida-plugins-good-1.0.9-3.fc14,moovida-1.0.9-3.fc14 moovida-plugins-bad-1.0.9-3.fc14, moovida-plugins-good-1.0.9-3.fc14, moovida-1.0.9-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. moovida-plugins-bad-1.0.9-3.fc13, moovida-plugins-good-1.0.9-3.fc13, moovida-1.0.9-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |