Bug 579227
| Summary: | Review Request: byobu - Light-weight, configurable window manager built upon GNU screen | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Klepek <jan.klepek> |
| Component: | Package Review | Assignee: | Daiki Ueno <dueno> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dueno, dustin.kirkland, dwmw2, fedora-package-review, notting, pahan |
| Target Milestone: | --- | Flags: | dueno:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | byobu-2.73-1.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-02 23:14:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jan Klepek
2010-04-03 12:28:07 UTC
Hi Jan, I'm trying to review.
1. *.mo listed twice
I got the following message when building:
warning: File listed twice: /usr/share/locale/bg/LC_MESSAGES/byobu.mo
The line "%{_datadir}/locale/*/LC_MESSAGES/%{name}.mo" in the %files section is unnecessary since "%files -f %{name}.lang" do the job.
2. messages are not translated
According to po/de.po, "Help" should be translated into "Hilfe" under German locales. However, it does not effect. Try:
LANG=de_DE.UTF-8 byobu-config
This is because wrong localedir is hard-coded in byobu-config:
byobu-config:31:PKG="byobu"
byobu-config:32:SHARE='/usr/share/'+PKG
...
byobu-config:52:gettext.bindtextdomain(PKG, SHARE+'/po')
The solution would be simply replacing the path in the last line with "/usr/share/locale".
3. desktop file
I'm not sure this is the issue - byobu.desktop is really useful for users?
The file also defines the Categories as GNOME;GTK;Utility, but neither GNOME nor GTK is used in byobu.
See "A. Registered Categories" of desktop files:
http://standards.freedesktop.org/menu-spec/latest/apa.html
1] fixed 2] fixed 3] so, upstream provide desktop file, why not use it...however, fixed Spec URL: http://hpejakle.fedorapeople.org/packages/byobu.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/byobu-2.67-2.fc11.src.rpm Desktop file is purely a matter of convenience for some users who prefer to always launch their gnome-terminals running Byobu. It's not enabled (displayed) by default in Ubuntu, but some users choose to turn it on and put it in their quick-launch bar. Feel free to drop it. Thanks, :-Dustin Setting SHARE to /usr/share/locale is problematic. Run byobu-config and select "Change keybinding set", you will see: ls: cannot access /usr/share/locale/keybindings: No such fil Spec URL: http://hpejakle.fedorapeople.org/packages/byobu.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/byobu-2.67-3.fc11.src.rpm hopefully final version I think it's ok, except that the latest changelog entry looks different from any of the examples listed in: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs it is what rpmdev-bumpspec generates, forgot to add email, otherwise it is same New Package CVS Request ======================= Package Name: byobu Short Description: Light-weight, configurable window manager built upon GNU screen Owners: hpejakle Branches: F-11 F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). byobu-2.73-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/byobu-2.73-1.fc11 byobu-2.73-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/byobu-2.73-1.fc12 byobu-2.73-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/byobu-2.73-1.fc13 Package Change Request ====================== Package Name: byobu New Branches: EL-4 EL-5 Owners: hpejakle cvs done. byobu-2.73-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. byobu-2.73-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. byobu-2.73-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |