Spec URL: http://hpejakle.fedorapeople.org/packages/byobu.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/byobu-2.67-1.fc11.src.rpm Description: Byobu is a Japanese term for decorative, multi-panel screens that serve as folding room dividers. As an open source project, Byobu is an elegant enhancement of the otherwise functional, plain, practical GNU Screen. Byobu includes an enhanced profile and configuration utilities for the GNU screen window manager, such as toggle-able system status notifications. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2092610 rpmlint: byobu.noarch: W: devel-file-in-non-devel-package /usr/bin/byobu-config it is ok, it is not devel file (it is script which is used for configuring byobu)
Hi Jan, I'm trying to review. 1. *.mo listed twice I got the following message when building: warning: File listed twice: /usr/share/locale/bg/LC_MESSAGES/byobu.mo The line "%{_datadir}/locale/*/LC_MESSAGES/%{name}.mo" in the %files section is unnecessary since "%files -f %{name}.lang" do the job. 2. messages are not translated According to po/de.po, "Help" should be translated into "Hilfe" under German locales. However, it does not effect. Try: LANG=de_DE.UTF-8 byobu-config This is because wrong localedir is hard-coded in byobu-config: byobu-config:31:PKG="byobu" byobu-config:32:SHARE='/usr/share/'+PKG ... byobu-config:52:gettext.bindtextdomain(PKG, SHARE+'/po') The solution would be simply replacing the path in the last line with "/usr/share/locale". 3. desktop file I'm not sure this is the issue - byobu.desktop is really useful for users? The file also defines the Categories as GNOME;GTK;Utility, but neither GNOME nor GTK is used in byobu. See "A. Registered Categories" of desktop files: http://standards.freedesktop.org/menu-spec/latest/apa.html
1] fixed 2] fixed 3] so, upstream provide desktop file, why not use it...however, fixed Spec URL: http://hpejakle.fedorapeople.org/packages/byobu.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/byobu-2.67-2.fc11.src.rpm
Desktop file is purely a matter of convenience for some users who prefer to always launch their gnome-terminals running Byobu. It's not enabled (displayed) by default in Ubuntu, but some users choose to turn it on and put it in their quick-launch bar. Feel free to drop it. Thanks, :-Dustin
Setting SHARE to /usr/share/locale is problematic. Run byobu-config and select "Change keybinding set", you will see: ls: cannot access /usr/share/locale/keybindings: No such fil
Spec URL: http://hpejakle.fedorapeople.org/packages/byobu.spec SRPM URL: http://hpejakle.fedorapeople.org/packages/byobu-2.67-3.fc11.src.rpm hopefully final version
I think it's ok, except that the latest changelog entry looks different from any of the examples listed in: https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
it is what rpmdev-bumpspec generates, forgot to add email, otherwise it is same New Package CVS Request ======================= Package Name: byobu Short Description: Light-weight, configurable window manager built upon GNU screen Owners: hpejakle Branches: F-11 F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
byobu-2.73-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/byobu-2.73-1.fc11
byobu-2.73-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/byobu-2.73-1.fc12
byobu-2.73-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/byobu-2.73-1.fc13
Package Change Request ====================== Package Name: byobu New Branches: EL-4 EL-5 Owners: hpejakle
cvs done.
byobu-2.73-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
byobu-2.73-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
byobu-2.73-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.