Bug 579452
| Summary: | Please package po-mode (spec file patch attached) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Underwood <jonathan.underwood> | ||||||
| Component: | gettext | Assignee: | Jens Petersen <petersen> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | rawhide | CC: | i18n-bugs, kklic, petersen | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2010-06-15 07:27:22 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
*** Bug 142632 has been marked as a duplicate of this bug. *** Thanks for the patch. Applying in next gettext build for f14. Probably a bit late for f13? (but if you think we could still do there I guess) Just checking - what is the convention for naming emacs packages? Should it be emacs-gettext or emacs-po-mode? emacs-gettext seems a bit confusing to me but if that is the conventional naming then so be it. Not sure about F-13 - if we decide to do it, we'll also have to push an update to the main emacs package which removes po-mode from there. This close to release, it might raise eyebrows. Regarding naming, emacs-gettext is what the guidelines would indicate - see: https://fedoraproject.org/wiki/Packaging:Emacs However, I had the same worry you had when working up the patch. Perhaps the thing to do would be to call it emacs-gettext, and add a virtual provides for emacs-po-mode. (In reply to comment #4) > Regarding naming, emacs-gettext is what the guidelines would indicate - see: > > https://fedoraproject.org/wiki/Packaging:Emacs Ok, I believe you - I have been away from fedora elisp packaging for quite while. Though I couldn't see an explicit statement on it on that page... > However, I had the same worry you had when working up the patch. Perhaps the > thing to do would be to call it emacs-gettext, and add a virtual provides for > emacs-po-mode. Yeah good idea - I will do that then. Should be all done in gettext-0.17-17.fc14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2134922 Should I reassign this to emacs, clone this bug, or is there one open? Thanks Jens· Just pushed a build of emacs for devel with po-mode files removed: http://koji.fedoraproject.org/koji/taskinfo?taskID=2135915 I noticed that there was an old patch included in the emacs package for the old version of po-mode.el that was included in the emacs package. As far as I can see, that's not needed anymore with the upstream po-mode, but I could be wrong. Attaching the patch for you to look at. Created attachment 408914 [details]
Patch against old version of po-mode.el
|
Created attachment 404466 [details] Patch to spec file to create emacs-gettext subpackages Description of problem: Currently the Emacs major mode for editing po files is bundled into the Emacs package, forked at some point from the gettext tarball. Really, the gettext package should have subpackages for the emacs components and we should stop including po-mode in the Emacs package, since gettext is the upstream for po-mode. The attached patch (against the devel branch) does this. Please could you apply this? TIA.