Bug 580447

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2102352

There is already a Module::build package taken from perl source package. Is there a plan to split it ?

Yes, it is. Perl-sig is working few weeks on dual-live modules. It was discussed on perl mailing list. https://fedoraproject.org/wiki/Perl/updates

Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2217469

There's a couple things going on here:

In %files, we need to use %{perl_privlib} rather than %{perl_vendorlib} (as this is duallifed/core).

I'd feel a touch better if we invoked %{perl_default_filter}, but it's not strictly required. :)

While we don't need to do this for the subpackage, for this independent package we should BR the extra bits to fully exercise the test suite (except for the scary bits marked "EXPERIMENTAL"):

perl(PAR::Dist)
perl(Archive::Tar)

I didn't check the "TEST_SIGNATURE" parts, but if it works sanely in the buildsys (might not if it needs, say, network access to keyservers or somesuch) we should enable it as well.

A newer version has been released; normally I wouldn't consider this a blocker for you, but as long as we're making these other changes...

I wasn't able to add TEST_SIGNATURE, but I fix all other parts. I suppose it's  test more for developers of this module anyway.

http://mmaslano.fedorapeople.org/review/perl-Module-Build-0.3607-1.fc13.src.rpm
http://mmaslano.fedorapeople.org/review/perl-Module-Build.spec

Koji (success) http://koji.fedoraproject.org/koji/taskinfo?taskID=2236371

The perl_default_filter macro needs to be invoked as %{?perl_default_filter},
and needs to be invoked right before the first %description section, to avoid
any possible scriptlet contamination.  I don't think TEST_MB_EXPERIMENTAL
should be set, but it's your call -- and if you do want it set, to be
effective it should be set in the %check section.

Update for the above, and I'll approve :)

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2236371

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Latest version (0.3607) is being packaged.

Source tarballs match upstream (sha1sum):
dde7a241bc1e4ede2497e25a4253833dc7d95469 Module-Build-0.3607.tar.gz
dde7a241bc1e4ede2497e25a4253833dc7d95469 Module-Build-0.3607.tar.gz.srpm

Final provides / requires are sane:

====> rpmlint perl-Module-Build.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

======> perl-Module-Build-0.3607-1.fc14.noarch.rpm <======
====> rpmlint
perl-Module-Build.noarch: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
perl(Module::Build) = 0.3607
perl(Module::Build::Base) = 0.3607
perl(Module::Build::Compat) = 0.3607
perl(Module::Build::Config) = 0.3607
perl(Module::Build::ConfigData)  
perl(Module::Build::Cookbook) = 0.3607
perl(Module::Build::Dumper) = 0.3607
perl(Module::Build::ModuleInfo) = 0.3607
perl(Module::Build::Notes) = 0.3607
perl(Module::Build::PPMMaker) = 0.3607
perl(Module::Build::Platform::Amiga) = 0.3607
perl(Module::Build::Platform::Default) = 0.3607
perl(Module::Build::Platform::EBCDIC) = 0.3607
perl(Module::Build::Platform::MPEiX) = 0.3607
perl(Module::Build::Platform::MacOS) = 0.3607
perl(Module::Build::Platform::RiscOS) = 0.3607
perl(Module::Build::Platform::Unix) = 0.3607
perl(Module::Build::Platform::VMS) = 0.3607
perl(Module::Build::Platform::VOS) = 0.3607
perl(Module::Build::Platform::Windows) = 0.3607
perl(Module::Build::Platform::aix) = 0.3607
perl(Module::Build::Platform::cygwin) = 0.3607
perl(Module::Build::Platform::darwin) = 0.3607
perl(Module::Build::Platform::os2) = 0.3607
perl(Module::Build::PodParser) = 0.3607
perl(Module::Build::Version) = 0.77
perl(Module::Build::YAML) = 1.40
perl(inc::latest) = 0.3607
perl(inc::latest::private) = 0.3607
perl-Module-Build = 0.3607-1.fc14
====> requires
/usr/bin/perl  
perl(:MODULE_COMPAT_5.10.1)  
perl(Carp)  
perl(Config)  
perl(Cwd)  
perl(Data::Dumper)  
perl(ExtUtils::CBuilder) >= 0.27
perl(ExtUtils::Install)  
perl(ExtUtils::Install) >= 0.3
perl(ExtUtils::MakeMaker)  
perl(ExtUtils::Manifest) >= 1.54
perl(ExtUtils::Mkbootstrap)  
perl(ExtUtils::ParseXS) >= 2.21
perl(File::Basename)  
perl(File::Compare)  
perl(File::Copy)  
perl(File::Find)  
perl(File::Path)  
perl(File::Spec)  
perl(Getopt::Long)  
perl(IO::File)  
perl(Module::Build)  
perl(Module::Build) >= 0.25
perl(Module::Build::Base)  
perl(Module::Build::Compat) >= 0.02
perl(Module::Build::Config)  
perl(Module::Build::Dumper)  
perl(Module::Build::ModuleInfo)  
perl(Module::Build::Notes)  
perl(Module::Build::Platform::Unix)  
perl(Module::Build::Version)  
perl(Text::ParseWords)  
perl(inc::latest::private)  
perl(strict)  
perl(vars)  
perl(version) >= 0.74
====> obsoletes
====> conflicts

======> perl-Module-Build-0.3607-1.fc14.src.rpm <======
====> rpmlint
perl-Module-Build.src: W: spelling-error %description -l en_US subclassing -> sub classing, sub-classing, subclass
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
====> provides
====> requires
perl(Archive::Tar)  
perl(ExtUtils::CBuilder) >= 0.27
perl(ExtUtils::Install) >= 0.3
perl(ExtUtils::Manifest) >= 1.54
perl(ExtUtils::Mkbootstrap)  
perl(ExtUtils::ParseXS) >= 2.21
perl(Module::Signature)  
perl(PAR::Dist)  
perl(Pod::Readme)  
perl(Software::License)  
perl(Test::Harness) >= 3.16
perl(Test::More) >= 0.49
perl(version) >= 0.74
====> obsoletes
====> conflicts

(In reply to comment #6)
> I wasn't able to add TEST_SIGNATURE, but I fix all other parts. I suppose it's 
> test more for developers of this module anyway.
> 
> http://mmaslano.fedorapeople.org/review/perl-Module-Build-0.3607-1.fc13.src.rpm
> http://mmaslano.fedorapeople.org/review/perl-Module-Build.spec    

I got TEST_SIGNATURE to work by creating my own keypair, sticking it in a tarball and using that:

http://trac.city-fan.org/cfo-trac/browser/perl-Module-Build/trunk/perl-Module-Build.spec

SRPM containing keypair:
http://mirror.city-fan.org/ftp/contrib/perl-modules/SRPMS/perl-Module-Build-0.3607-2.fc14.src.rpm

(In reply to comment #9)
> (In reply to comment #6)
> > I wasn't able to add TEST_SIGNATURE, but I fix all other parts. I suppose it's 
> > test more for developers of this module anyway.
> > 
> > http://mmaslano.fedorapeople.org/review/perl-Module-Build-0.3607-1.fc13.src.rpm
> > http://mmaslano.fedorapeople.org/review/perl-Module-Build.spec    
> 
> I got TEST_SIGNATURE to work by creating my own keypair, sticking it in a
> tarball and using that:
> 
> http://trac.city-fan.org/cfo-trac/browser/perl-Module-Build/trunk/perl-Module-Build.spec
> 
> SRPM containing keypair:
> http://mirror.city-fan.org/ftp/contrib/perl-modules/SRPMS/perl-Module-Build-0.3607-2.fc14.src.rpm    

Thanks, I'll use it ;-)

http://mmaslano.fedorapeople.org/review/perl-Module-Build-0.3607-2.fc13.src.rpm
http://mmaslano.fedorapeople.org/review/perl-Module-Build.spec

Macro was moved to the correct position.

Ping?

I suppose Chris is still not available, so could anyone else take this review and finish it?

Basically, Chris has said it all.

My comments:

1. Remove the unnecessary tab character on line 67.
2. I suppose we could go with 'sub-classing' to make rpmlint happier.
3. I don't think the MB_TEST_EXPERIMENTAL is really needed. But again, it's up to you.

All in all, it looks okay.

I removed experimental test and tab, but I won't change upstream description.
http://mmaslano.fedorapeople.org/review/perl-Module-Build.spec

It's okay with me.

New Package SCM Request
=======================
Package Name: perl-Module-Build
Short Description: Build and install Perl modules
Owners: mmaslano psabata ppisar
Branches: F-13 F-14
InitialCC: perl-sig

ok, this package already exists (but is retired and blocked). 

Can you: 

a) Add a Package Change template here with the branches and owners you need. 
b) File a ticket in rel-eng track and ask them to unblock it.

resetting fedora-cvs flag for now

Package Change Request
======================
Package Name: perl-Module-Build
New Branches: F-13 F-14
Owners: mmaslano psabata ppisar
InitialCC: perl-sig

Module::Build is needed in latest version for some modules. 

Ticket for unblock: https://fedorahosted.org/rel-eng/ticket/406

Git done (by process-git-requests).

(I'll note that this is showing as still orphaned in devel)

Yes, it's still orphaned in devel, so another change request?

Package Change Request
======================
Package Name: perl-Module-Build
New Branches: devel
Owners: mmaslano psabata ppisar
InitialCC: perl-sig

ok. I think I have 'undepreciated' this. Can you see if you can take owership
in the pkgdb web interface?

Reset the flag if you need anything further.

(In reply to comment #23)
> ok. I think I have 'undepreciated' this. Can you see if you can take owership
> in the pkgdb web interface?
> 
> Reset the flag if you need anything further.

Thank you. I'm owner now.