Bug 582147

Summary: Cleanup after porting to EL-5
Product: [Fedora] Fedora EPEL Reporter: Matěj Cepl <mcepl>
Component: pocoAssignee: Matěj Cepl <mcepl>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: el5CC: mcepl, udushlivy
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-13 11:39:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matěj Cepl 2010-04-14 09:29:34 UTC
Description of problem:
see bug 578484 comment 15:
> A couple of notes about the current poco-1.3.5-RH-old-SQLite.patch:
> 
> +// Attempt to make this build compatible with more recent versions of SQLite
> +// API.
> +#ifndef SQLITE_LOCKED_SHAREDCACHE
> +       #define SQLITE_LOCKED_SHAREDCACHE      (SQLITE_LOCKED | (1<<8) )
> +#endif
> 
> There are two reasons you're guaranteed never to receive this error code:
>  - It does not exist in sqlite-3.3.6 (the version in RHEL-5).
>  - You keep SQlite extended result codes disabled and this is one of them.
> So I find removing the two occurrences of "SQLITE_LOCKED_SHAREDCACHE" from poco
> source code cleaner than defining the macro.
> But it's not really wrong either way, so whatever.
> 
> 
> -               rc = sqlite3_prepare_v2(_pDB, pSql, -1, &pStmt, &pLeftover);
> +               rc = sqlite3_prepare(_pDB, pSql, -1, &pStmt, &pLeftover);
> 
> Yeah, as I said before, this change needs to be handled with care. It changes
> the way sqlite3_step() reports errors and I don't see 
> SQLiteStatementImpl::hasNext() changed appropriately. It won't be a big change,
> but it must be tested in error situations.

Comment 1 Matěj Cepl 2011-12-13 11:39:59 UTC
poco packages are now in the maintenance mode (bugfixes only) and I plan to orphan it as soon as spectrum-2 enters Fedora.

If anybody wants to take this bug (and whole poco) maintainership over, please, do so.