Bug 582147 - Cleanup after porting to EL-5
Summary: Cleanup after porting to EL-5
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: poco
Version: el5
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Matěj Cepl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-14 09:29 UTC by Matěj Cepl
Modified: 2018-04-11 16:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-12-13 11:39:59 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Matěj Cepl 2010-04-14 09:29:34 UTC
Description of problem:
see bug 578484 comment 15:
> A couple of notes about the current poco-1.3.5-RH-old-SQLite.patch:
> 
> +// Attempt to make this build compatible with more recent versions of SQLite
> +// API.
> +#ifndef SQLITE_LOCKED_SHAREDCACHE
> +       #define SQLITE_LOCKED_SHAREDCACHE      (SQLITE_LOCKED | (1<<8) )
> +#endif
> 
> There are two reasons you're guaranteed never to receive this error code:
>  - It does not exist in sqlite-3.3.6 (the version in RHEL-5).
>  - You keep SQlite extended result codes disabled and this is one of them.
> So I find removing the two occurrences of "SQLITE_LOCKED_SHAREDCACHE" from poco
> source code cleaner than defining the macro.
> But it's not really wrong either way, so whatever.
> 
> 
> -               rc = sqlite3_prepare_v2(_pDB, pSql, -1, &pStmt, &pLeftover);
> +               rc = sqlite3_prepare(_pDB, pSql, -1, &pStmt, &pLeftover);
> 
> Yeah, as I said before, this change needs to be handled with care. It changes
> the way sqlite3_step() reports errors and I don't see 
> SQLiteStatementImpl::hasNext() changed appropriately. It won't be a big change,
> but it must be tested in error situations.

Comment 1 Matěj Cepl 2011-12-13 11:39:59 UTC
poco packages are now in the maintenance mode (bugfixes only) and I plan to orphan it as soon as spectrum-2 enters Fedora.

If anybody wants to take this bug (and whole poco) maintainership over, please, do so.


Note You need to log in before you can comment on or make changes to this bug.