Bug 582163

Summary:	Review Request: perl-Test-Smoke - Perl core test smoke suite
Product:	[Fedora] Fedora	Reporter:	Marcela Mašláňová <mmaslano>
Component:	Package Review	Assignee:	Shakthi Kannan <shakthimaan>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, paul, perl-devel, shakthimaan
Target Milestone:	---	Flags:	shakthimaan: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-07-02 10:55:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2010-04-14 10:07:17 UTC

Spec URL: http://mmaslano.fedorapeople.org/review/perl-Test-Smoke.spec
SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Test-Smoke-1.43-1.fc13.src.rpm
Description: Test::Smoke exports $conf and read_config() by default.

Comment 1 Shakthi Kannan 2010-04-26 16:25:21 UTC

#01 Running rpmlint on the built RPM file yields:

$ rpmlint ../RPMS/i686/perl-Test-Smoke-*

perl-Test-Smoke.i686: E: no-binary
perl-Test-Smoke-debuginfo.i686: E: empty-debuginfo-package
2 packages and 0 specfiles checked; 2 errors, 0 warnings.

You need to use:

  BuildArch: noarch

# 02 For consistency, you can use:

- %{buildroot} instead of $RPM_BUILD_ROOT
- %{__rm} instead of rm
- %{__make} instead of make

Koji builds for F-12, F-13, F-14 and EL-5 are fine.

Comment 2 Shakthi Kannan 2010-05-11 03:20:49 UTC

Can you please update the .spec file with BuildArch?

Comment 3 Marcela Mašláňová 2010-05-12 06:52:43 UTC

Updated:
http://mmaslano.fedorapeople.org/review/perl-Test-Smoke-1.43-1.fc13.src.rpm
http://mmaslano.fedorapeople.org/review/perl-Test-Smoke.spec

That's not consistency. cpanspec generate it with $RPM_BUILD_ROOT and I'm also using in all other non-perl packages.

Comment 4 Paul Howarth 2010-05-12 07:04:30 UTC

The guidelines say to choose either the "%{buildroot}" form or the "$RPM_BUILD_ROOT" form (either are OK) but not to use both forms in the same spec file. So this spec is OK in that respect.

There is a redundant "/" between $RPM_BUILD_ROOT and %{_bindir} but to block on that would be nit-picking.

Comment 5 Shakthi Kannan 2010-05-12 11:53:06 UTC

What I meant by consistent ("cosmetic") look is the use of macros with % instead of $. Anyways, this is only a cosmetic change, and not essential! 

Thanks for your replies.

Comment 6 Shakthi Kannan 2010-06-22 08:40:18 UTC

Package looks good. Approved.

Comment 7 Marcela Mašláňová 2010-07-01 14:57:23 UTC

New Package CVS Request
=======================
Package Name: perl-Test-Smoke
Short Description: Perl core test smoke suite
Owners: mmaslano psabata ppisar
Branches: F-13
InitialCC: perl-sig

Comment 8 Jason Tibbitts 2010-07-01 17:33:39 UTC

CVS done (by process-cvs-requests.py).