Spec URL: http://mmaslano.fedorapeople.org/review/perl-Test-Smoke.spec SRPM URL: http://mmaslano.fedorapeople.org/review/perl-Test-Smoke-1.43-1.fc13.src.rpm Description: Test::Smoke exports $conf and read_config() by default.
#01 Running rpmlint on the built RPM file yields: $ rpmlint ../RPMS/i686/perl-Test-Smoke-* perl-Test-Smoke.i686: E: no-binary perl-Test-Smoke-debuginfo.i686: E: empty-debuginfo-package 2 packages and 0 specfiles checked; 2 errors, 0 warnings. You need to use: BuildArch: noarch # 02 For consistency, you can use: - %{buildroot} instead of $RPM_BUILD_ROOT - %{__rm} instead of rm - %{__make} instead of make Koji builds for F-12, F-13, F-14 and EL-5 are fine.
Can you please update the .spec file with BuildArch?
Updated: http://mmaslano.fedorapeople.org/review/perl-Test-Smoke-1.43-1.fc13.src.rpm http://mmaslano.fedorapeople.org/review/perl-Test-Smoke.spec That's not consistency. cpanspec generate it with $RPM_BUILD_ROOT and I'm also using in all other non-perl packages.
The guidelines say to choose either the "%{buildroot}" form or the "$RPM_BUILD_ROOT" form (either are OK) but not to use both forms in the same spec file. So this spec is OK in that respect. There is a redundant "/" between $RPM_BUILD_ROOT and %{_bindir} but to block on that would be nit-picking.
What I meant by consistent ("cosmetic") look is the use of macros with % instead of $. Anyways, this is only a cosmetic change, and not essential! Thanks for your replies.
Package looks good. Approved.
New Package CVS Request ======================= Package Name: perl-Test-Smoke Short Description: Perl core test smoke suite Owners: mmaslano psabata ppisar Branches: F-13 InitialCC: perl-sig
CVS done (by process-cvs-requests.py).