Bug 582352

Package and SPEC name: ok
License: ok
Upstream source code: ok (85679746aa5b50105b16b46924b9b6ad  ../SOURCES/Sentinella-0.6.0.tar.gz)

Do not use Requires: libsysactivity!!! If version 0.5.1 and greater is requires - use libsysactivity-devel >= 0.5.1. I'm not sure about that spurious-executable-perms in -debuginfo.

Fixed Requires

Spec URL: http://thomasj.fedorapeople.org/reviews/sentinella.spec
SRPM URL: http://thomasj.fedorapeople.org/reviews/sentinella-0.6.0-2.fc12.src.rpm

- As it's GUI application, it should install desktop file - see https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files.
- As package installs icon, icons cache should be recreated.

Last question - what's the license of included sounds? Looks like collection of alarms found on internet...

Fixed .desktop file, well spotted, thanks.
Fixed icon cache
Mail sent upstream for sounds license clarification.

Spec URL: http://thomasj.fedorapeople.org/reviews/sentinella.spec
SRPM URL: http://thomasj.fedorapeople.org/reviews/sentinella-0.6.0-3.fc12.src.rpm

Thanks Thomas,
let me know once sound files license is clarified.

Added Carlos (the developer) to CC to clarify the sounds license included with sentinella.

Well, Carlos already sent me a mail, following:

The soundfiles are released under Creative Commons Sampling plus 1.0
license but i've just realized that it might be not free (it limits
the way you distribute and use it). Please, let me note if its not ok.
I can make the soundfiles by my own or ask for help in sourceforge
(and make a minor release soon).

Let me find out what our License page knows..

Yep, bad license:

http://fedoraproject.org/wiki/Licensing

Ok Carlos, it won't be approved with that soundfiles (or to be more precise, with that license). Sorry.

Yes, please change licence or new files should be used. What about KDE default sounds usage? Do this cover all needed sounds (is it possible to map events there?)

I've just asked for help in sourceforge so i guess i will have new audio samples in few days (released under CC-BY or CC-BY-SA). I will try also this minor release ships some translations.

(In reply to comment #11)
> I've just asked for help in sourceforge so i guess i will have new audio
> samples in few days (released under CC-BY or CC-BY-SA). I will try also this
> minor release ships some translations.    

Great, thank you Carlos!

I replaced the old files with three new samples made by myself. I release them under CC-BY-SA, there is a notice about it in the about dialog.

Now i'm waiting for the completion of a couple of translations and then i will release the 0.6.1 version.

Awesome, thank you very much Carlos!

Hi, version 0.6.1 is just released as promised. Here is the changelog so you don't miss what have changed:

 * Replaced audio files released under CC sampling plus by three self-made files released under CC-BY-SA 3.0
 * Added six new translations.
 * The final binary name will be "sentinella" (with lower "s").
 * Added .desktop file.
 * Now the condition runs in a high-prioritized thread.

Spec URL: http://thomasj.fedorapeople.org/reviews/sentinella.spec
SRPM URL:
http://thomasj.fedorapeople.org/reviews/sentinella-0.6.1-1.fc12.src.rpm

Upstreamed patch to fix the .desktop file:
http://sourceforge.net/tracker/?func=detail&atid=1179456&aid=2997765&group_id=277778

rpmlint sentinella.spec ../SRPMS/sentinella-0.6.1-1.fc12.src.rpm ../RPMS/x86_64/sentinella-*0.6.1*
sentinella-debuginfo.x86_64: E: world-writable /usr/src/debug/Sentinella-0.6.1/x86_64-redhat-linux-gnu/src/ui_MainWindow.h 0666
3 packages and 1 specfiles checked; 1 errors, 0 warnings.

The world-writable hurts me. The ui_MainWindow.h gets created trough compile time. I have no clue how to fix/patch this.

Ok, i fixed the world-writable. Links above.

Great, thanks Thomas and Carlos. All issues are fixed, rpmlint output is clean, new sources md5sum is ok (6d00dc3b03ad7eba43bd6ec4c41faae1).

APPROVED

New Package CVS Request
=======================
Package Name: sentinella
Short Description: Monitors your system activity and takes chosen action
Owners: thomasj
Branches: F-12 F-13
InitialCC:

CVS Done

sentinella-0.6.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/sentinella-0.6.1-1.fc13

sentinella-0.6.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/sentinella-0.6.1-1.fc12

sentinella-0.6.1-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sentinella'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/sentinella-0.6.1-1.fc13

sentinella-0.6.1-1.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update sentinella'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/sentinella-0.6.1-1.fc12

sentinella-0.6.1-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

sentinella-0.6.1-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.