Spec URL: http://thomasj.fedorapeople.org/reviews/libsysactivity.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/libsysactivity-0.5.1-1.fc12.src.rpm Description: A lightweight library that retrieves statistics of the system's activity in a portable and thread safe way. In each OS that it supports it offers the same API for retrieving the activity of: hard disks, CPUs, memory, processes and network interfaces. http://koji.fedoraproject.org/koji/taskinfo?taskID=2115395 [thomas@tusdell SPECS]$ rpmlint libsysactivity.spec ../RPMS/x86_64/libsysactivity-* ../SRPMS/libsysactivity-0.5.1-1.fc12.src.rpm libsysactivity-devel.x86_64: W: no-documentation 4 packages and 1 specfiles checked; 0 errors, 1 warnings.
Rpmlint: ok (no devel docs) Package and SPEC name: ok, upstream ships it with lib prefix License: ok Upstream source code: ok (966ba9884964803509122cb2fc6f9611 libsysactivity-0.5.1.tar.gz) Package builds: ok, see scratch build + tested locally ldconfig: ok BuildRequires: ok Devel split: ok No libtools archives: ok Just a few notes - please fix summary - use "Library" instead of just "Lib" - looks better (can be fixed later in CVS) and the hardcoded lib in CMakeLists.txt should be fixed upstream. But works correctly. APPROVED
Fixed Summary Spec URL: http://thomasj.fedorapeople.org/reviews/libsysactivity.spec SRPM URL: http://thomasj.fedorapeople.org/reviews/libsysactivity-0.5.1-2.fc12.src.rpm Thanks for the review Jaroslav!
New Package CVS Request ======================= Package Name: libsysactivity Short Description: Library for retrieving statistics of the system`s activity Owners: thomasj Branches: F-11 F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
libsysactivity-0.5.1-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libsysactivity-0.5.1-2.fc12
libsysactivity-0.5.1-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/libsysactivity-0.5.1-2.fc11
libsysactivity-0.5.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libsysactivity-0.5.1-2.fc13
libsysactivity-0.5.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libsysactivity'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libsysactivity-0.5.1-2.fc13
libsysactivity-0.5.1-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libsysactivity'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libsysactivity-0.5.1-2.fc12
libsysactivity-0.5.1-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libsysactivity'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/libsysactivity-0.5.1-2.fc11
(In reply to comment #1) > Rpmlint: ok (no devel docs) > Package and SPEC name: ok, upstream ships it with lib prefix > License: ok > Upstream source code: ok (966ba9884964803509122cb2fc6f9611 > libsysactivity-0.5.1.tar.gz) > Package builds: ok, see scratch build + tested locally > ldconfig: ok > BuildRequires: ok > Devel split: ok > No libtools archives: ok > > Just a few notes - please fix summary - use "Library" instead of just "Lib" - > looks better (can be fixed later in CVS) and the hardcoded lib in > CMakeLists.txt should be fixed upstream. But works correctly. > > APPROVED Hi. I'm the author of libsysactivity. You say that there is something wrong in the CMakeLists.txt (which one?). Please, tell me what is it and why so i can fix it for the next release. Thanks.
Hi Carlos :) sed -i 's,${CMAKE_INSTALL_PREFIX}/lib,%{_libdir},' src/CMakeLists.txt
or even better, sed -i 's,${CMAKE_INSTALL_PREFIX}/lib,${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX},' src/CMakeLists.txt
Done upstream. Will be fixed in the next release.
libsysactivity-0.5.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
libsysactivity-0.5.1-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
libsysactivity-0.5.1-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.