Bug 582894
| Summary: | Review Request: emacs-common-ddskk - Daredevil SKK - Simple Kana to Kanji conversion program for Emacs | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daiki Ueno <dueno> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, notting, panemade, petersen |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | emacs-common-ddskk-14.1-6.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-22 03:16:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daiki Ueno
2010-04-16 06:27:01 UTC
*** Bug 531688 has been marked as a duplicate of this bug. *** *** Bug 532624 has been marked as a duplicate of this bug. *** Spec URL: http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk.spec SRPM URL: http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk-14.1-1.fc13.src.rpm Updated. 14.1 is the first upstream release officially supporting Emacs 23. Suggestions 1) drop buildroot, %clean and cleaning of buildroot in %install 2) Use correct info scriptlet. See http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo 3) Drop following and its references in BR: and R: %global apel_minver 10.7 We already build required dependencies in release and so we should not need to write explicit versions for BR: and R: more see http://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires 4) use following for main package %defattr(-,root,root,-) Thanks, updated: Spec URL: http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk.spec SRPM URL: http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk-14.1-2.fc13.src.rpm Sorry, the SRPM URL was wrong. Updated with minor fix: Spec URL: http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk.spec SRPM URL: http://ueno.fedorapeople.org/emacs-common-ddskk/emacs-common-ddskk-14.1-3.fc14.src.rpm I don't think you need all the ChangeLog.* files. Just add ChangeLog file.
for macros, good to use curly brackets.
another issue directory ownership. This package need to own following directory
%{_xemacs_sitepkgdir}/etc
APPROVED.
Thanks for the review, Parag. New Package SCM Request ======================= Package Name: emacs-common-ddskk Short Description: Daredevil SKK - Simple Kana to Kanji conversion program for Emacs Owners: ueno Branches: f14 f13 InitialCC: i18n-team Git done (by process-git-requests). emacs-common-ddskk-14.1-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/emacs-common-ddskk-14.1-4.fc14 emacs-common-ddskk-14.1-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/emacs-common-ddskk-14.1-4.fc13 Thanks. emacs-common-ddskk-14.1-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. emacs-common-ddskk-14.1-6.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/emacs-common-ddskk-14.1-6.fc14 emacs-common-ddskk-14.1-6.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/emacs-common-ddskk-14.1-6.fc13 emacs-common-ddskk-14.1-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. emacs-common-ddskk-14.1-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |