Bug 584007
| Summary: | Return of a command substitution from within another command substitution causes stdin of coprocess to be closed in a ksh script | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Siddhesh Poyarekar <spoyarek> | ||||
| Component: | ksh | Assignee: | Michal Hlavinka <mhlavink> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | rawhide | CC: | mhlavink, mnewsome | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ksh-20100309-5.fc11 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 584704 (view as bug list) | Environment: | |||||
| Last Closed: | 2010-05-05 11:40:19 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
Created attachment 407821 [details]
Close coprocess file descriptors only if the coprocess pid is nonzero
The root cause for this is the race condition between the job_reap called within the signal handler and job_wait in the parent process. job_reap sets the lastpid to the pid of the process that exited last, so if job_wait is called after it, it correctly compares a valid pid against the coprocess pid to see if it is the coprocess that has ended.
But in case of a command substitution, the job env (including the coprocess pid) is backed up and reinitialized, hence making the coprocess pid 0. In this case, if job_wait happens to execute before job_reap, it compares the 0 coprocess id with the 0 lastpid (since it has not been set through the signal handler yet) and goes on to close the coprocess assuming that it has quit.
Attached fix ensures that the coprocess pid is actually set before trying to close its handlers.
Hi, thanks for the report and especially for the patch. I can reproduce this bug and confirm attached patch fixes it. I've emailed all information to upstream and I'm waiting for their response. ksh-20100309-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/ksh-20100309-4.fc12 ksh-20100309-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/ksh-20100309-4.fc11 ksh-20100309-4.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/ksh-20100309-4.fc13 ksh-20100309-5.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. ksh-20100309-5.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. ksh-20100309-5.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Return of a command substitution from within another command substitution causes stdin of coprocess to be closed in a ksh script. Version-Release number of selected component (if applicable): ksh-20100309-3.fc14.x86_64 How reproducible: Always Steps to Reproduce: 1. Execute the following script in ksh: ####################################### #!/bin/ksh set -e co_process() { while read line do printf "\n%s(): Read line from 'stdin'\n" "${.sh.fun}" >/dev/tty done printf "\n%s(): Exiting -- EOF on read of 'stdin'.\n" "${.sh.fun}" >/dev/tty # kill the main shell process when the end-of-file is detected on 'stdin'. kill $$ } co_process |& loop_count=0 while : do (( loop_count++ )) printf "%05d: %s\r" "${loop_count}" "$( echo $( /bin/ls ) )" done ####################################### Actual results: Script ends with the following output: test_script.ksh: Exiting -- EOF on read of 'stdin'.\n Expected results: Script should run in an infinite loop. Additional info: