Bug 584355

Summary: ldap group authorization components in need of refactoring.
Product: [Other] RHQ Project Reporter: Simeon Pinder <spinder>
Component: Core ServerAssignee: Simeon Pinder <spinder>
Status: CLOSED NOTABUG QA Contact: Corey Welton <cwelton>
Severity: medium Docs Contact:
Priority: low    
Version: unspecified   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-04-28 14:25:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 577267    

Description Simeon Pinder 2010-04-21 13:28:28 UTC 
Description of problem:
While working on several ldap related bugs, I discovered that the LdapGroup authz classes are inconsistent with current RHQ implementation model: named queries on wrong class definitions, not included in the standard SLSB model, constants hard coded, etc.  These components need to be refactored to be consistently defined like the other Bean manager and database components. 

Version-Release number of selected component (if applicable):
All.

How reproducible:
N/A

Steps to Reproduce:
1.N/A. Src level refactoring changes required.
  
Actual results:
Implementation works.

Expected results:
Implementation works, but consistently defined like other slsb methods.

Additional info:
Will likely require code review.
Comment 1 Simeon Pinder 2010-04-28 14:25:06 UTC 
Changes made and applied:

Fixed in successful builds >= 266. 

git hash:
20fe0ece0175e24f2a8905c3a666011802decea5

No new or existing features should have been changed or made here.  There is nothing to QA outside of regular testing of functionality to avoid regressions. Simply closing this bz.