Bug 584355 - ldap group authorization components in need of refactoring.
Summary: ldap group authorization components in need of refactoring.
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: RHQ Project
Classification: Other
Component: Core Server
Version: unspecified
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
: ---
Assignee: Simeon Pinder
QA Contact: Corey Welton
URL:
Whiteboard:
Depends On:
Blocks: jon24-ldap
TreeView+ depends on / blocked
 
Reported: 2010-04-21 13:28 UTC by Simeon Pinder
Modified: 2010-04-28 14:25 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-04-28 14:25:06 UTC
Embargoed:


Attachments (Terms of Use)

Description Simeon Pinder 2010-04-21 13:28:28 UTC
Description of problem:
While working on several ldap related bugs, I discovered that the LdapGroup authz classes are inconsistent with current RHQ implementation model: named queries on wrong class definitions, not included in the standard SLSB model, constants hard coded, etc.  These components need to be refactored to be consistently defined like the other Bean manager and database components. 

Version-Release number of selected component (if applicable):
All.

How reproducible:
N/A

Steps to Reproduce:
1.N/A. Src level refactoring changes required.
  
Actual results:
Implementation works.

Expected results:
Implementation works, but consistently defined like other slsb methods.

Additional info:
Will likely require code review.

Comment 1 Simeon Pinder 2010-04-28 14:25:06 UTC
Changes made and applied:

Fixed in successful builds >= 266. 

git hash:
20fe0ece0175e24f2a8905c3a666011802decea5

No new or existing features should have been changed or made here.  There is nothing to QA outside of regular testing of functionality to avoid regressions. Simply closing this bz.


Note You need to log in before you can comment on or make changes to this bug.