Bug 585151

Summary: Review Request: R-sciplot - Scientific Graphing Functions for Factorial Designs
Product: [Fedora] Fedora Reporter: josef radinger <cheese>
Component: Package ReviewAssignee: Pierre-YvesChibon <pingou>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, pingou
Target Milestone: ---Flags: pingou: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: R-sciplot-1.0.7-4.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-05-05 06:29:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description josef radinger 2010-04-23 09:26:20 UTC
Spec URL: http://www.nosuchhost.net/~cheese/fedora/packages/devel/R-sciplot.spec
SRPM URL: http://www.nosuchhost.net/~cheese/fedora/packages/devel/R-sciplot-1.0-1.fc12.src.rpm
Description: 

A collection of functions that creates graphs with error bars for data collected
from one-way or higher factorial designs

Comment 1 Pierre-YvesChibon 2010-04-28 09:57:21 UTC
Quickly:
- Fix version
  The version of this package is 1.0.7 not 1.0 cf 
  http://fedoraproject.org/wiki/Packaging:R#R_version
- Fix %check
- Fix %changelog
  Please update the format of the changelog, the version-release should be on the same line as the changelog entree.
- Please include the README and the CHANGELOG as doc

Comment 2 josef radinger 2010-04-30 19:45:02 UTC
(In reply to comment #1)
> Quickly:
> - Fix version
>   The version of this package is 1.0.7 not 1.0 cf 
>   http://fedoraproject.org/wiki/Packaging:R#R_version
agreed

> - Fix %check
agreed

> - Fix %changelog
>   Please update the format of the changelog, the version-release should be on
> the same line as the changelog entree.
is an allowed format according to 
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

> - Please include the README and the CHANGELOG as doc    
fixed

new SRPM:
http://www.nosuchhost.net/~cheese/fedora/packages/devel/R-sciplot-1.0.7-2.fc12.src.rpm

and thanks for you time and input

Comment 3 Pierre-YvesChibon 2010-05-01 09:35:35 UTC
* source files match upstream:
   md5sum sciplot_1.0-7.tar.gz 
62bf0776b34339e38f547df46a24f1d6  sciplot_1.0-7.tar.gz
   md5sum rpmbuild/SOURCES/sciplot_1.0-7.tar.gz 
62bf0776b34339e38f547df46a24f1d6  rpmbuild/SOURCES/sciplot_1.0-7.tar.gz

* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=2152947).
* package installs properly
* rpmlint is silent.
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.
* final provides and requires are sane
* %check is present and all tests pass.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

** APPROVED **

Comment 4 josef radinger 2010-05-01 15:53:32 UTC
how did you generate that list? is this from a script?
thanks.

Comment 5 josef radinger 2010-05-01 16:00:02 UTC
New Package CVS Request
=======================
Package Name: R-sciplot
Short Description: Scientific Graphing Functions for Factorial Designs
Owners: cheese
Branches: F-12 F-13
InitialCC: cheese

Comment 6 Pierre-YvesChibon 2010-05-01 16:22:57 UTC
(In reply to comment #4)
> how did you generate that list? is this from a script?
> thanks.    

From a former review of mine, and following the review guidelines.

Comment 7 Kevin Fenzi 2010-05-04 02:55:31 UTC
CVS done (by process-cvs-requests.py).

Comment 8 Fedora Update System 2010-05-05 06:30:06 UTC
R-sciplot-1.0.7-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/R-sciplot-1.0.7-2.fc12

Comment 9 Fedora Update System 2010-05-05 06:31:21 UTC
R-sciplot-1.0.7-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/R-sciplot-1.0.7-2.fc13

Comment 10 Pierre-YvesChibon 2010-05-06 17:52:50 UTC
arf I am seen this too late, you are missing this:
BuildRequires:    R-devel, tex(latex)
see http://fedoraproject.org/wiki/Packaging/R

Comment 11 Fedora Update System 2010-05-08 12:43:17 UTC
R-sciplot-1.0.7-4.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/R-sciplot-1.0.7-4.fc12

Comment 12 Fedora Update System 2010-05-08 12:43:20 UTC
R-sciplot-1.0.7-4.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/R-sciplot-1.0.7-4.fc13

Comment 13 Fedora Update System 2010-07-13 07:25:06 UTC
R-sciplot-1.0.7-4.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2010-07-13 07:34:02 UTC
R-sciplot-1.0.7-4.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.