Bug 586079
| Summary: | Missing the "ASSOCIATE..." and "DISSASSOCIATE SELECTED" buttons within a repository table "Content Sources Associated with This Repository" | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | John Sefler <jsefler> |
| Component: | Content | Assignee: | Simeon Pinder <spinder> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Corey Welton <cwelton> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.4 | CC: | cwelton, ian.springer, smohan, whayutin |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 2.4 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-12 16:56:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 586123 | ||
| Attachments: | |||
|
Description
John Sefler
2010-04-26 18:52:34 UTC
The associate/disassociate functionality was intentionally disabled (commented out), since it is needed for JON. For JON, we only need to support the use case of one content provider (i.e. the CSP or a local mirror of the CSP) per repo. So you can disable the associated tests. You might want to keep them around in case we have new use cases in a future release of JON that require restoring the functionality. Now that you have removed the associate/disassociate functionality, there is no need for the checkboxes. See attached screenshot. This applies to both the "Content Sources Associated with This Repository" table in the selected Repository (i.e. JBoss Patches) page AND the "Repositories" table in the selected Content Source page. Moving back to ON_DEV Created attachment 410997 [details]
Now that you have removed the associate/disassociate functionality, there is no need for the checkboxes
The problem with the logic in comment #1 is is that even if we are only supporting a 1:1 content source:repo, you should still be able to create a new content source, a new repo, and associate the two for example, we have the CSP content source/repo preconfigured, but let's say i want to create another one -- perhaps a different CSP login, or one that uses http vs https or... any number of things. Even if I am not trying to associate multiple, new repos with a pre-existing Content source, if we have removed the associate/disassociate buttons, I can no longer connect the two. Referring to cswiii's comment. How much effort would it be to add these associate/disassociate buttons back I just commented them out in the xhtml files, so it would not be much effort. Re-enabled associate/dissassociate buttons. Available in successful master build >= 307, and commit hash: ce0d8ab908a52df1bc7826de06d848c8300a343f One more request... Can you update the InfoBlock messages to spell out the word "repo" -> "repository". Associated [1] content sources with repo -> Associated [1] content sources with repository. Disassociated [1] content sources from repo -> Disassociated [1] content sources from repository. moving back to ON_DEV Created attachment 414844 [details]
Update the InfoBlock messages to spell out the word "repo" -> "repository"
Yep. Fixed it there and in a few other places in the code tree. Available in successful master builds >= 332. with commit hash 49e72b33dbb715fb390cdcfe6c64ed727addaa8b Recent build appears to have undone the Re-enablement of the associate/dissassociate buttons committed in comment #9 The recent build which is missing the buttons is a19ca6b which contains the comment #9 commit: $ git rev-list a19ca6b | grep ce0d8ab908a52df1bc7826de06d848c8300a343f ce0d8ab908a52df1bc7826de06d848c8300a343f Moving back to ON_DEV This was caused by a curious reversion of the applied fix after checkin. I re-applied the fix and the error message from the screenshot should be fixed now in successful build of master >= 355, and git hash: bd8ee1ee291e656dfec223110ed51d0cb24d2219. QA Verified. Mass-closure of verified bugs against JON. |