Bug 587320
| Summary: | Review Request: gnome-icon-theme-symbolic - Symbolic GNOME icons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, jmccann, mclasen, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-05-21 15:34:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Bastien Nocera
2010-04-29 15:32:43 UTC
Note that gnome-icon-theme in rawhide does not have the scalable directories in index.theme, since I've kicked out all our non-upstream additions. You probably want to fix that both upstream and in rawhide. Some more informal comments: Requires(posttrans): gtk2 >= 2.6.2 Requires(postun): gtk2 >= 2.6.2 I believe we generally don't add this as a dep (thats one of the reasons for the ||: construct) %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT The rm -rf is no longer needed in %install %clean rm -rf $RPM_BUILD_ROOT And neither is %clean Updated: http://people.fedoraproject.org/~hadess/gnome-icon-theme-symbolic/gnome-icon-theme-symbolic-2.30.0-2.fc12.src.rpm http://people.fedoraproject.org/~hadess/gnome-icon-theme-symbolic/gnome-icon-theme-symbolic.spec builds fine in mock rpmlint output: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gnome-icon-theme-symbolic-2.30.0-2.fc14.noarch.rpm gnome-icon-theme-symbolic.noarch: W: no-url-tag 1 packages and 0 specfiles checked; 0 errors, 1 warnings. package name: ok spec file name: ok packaging guidelines: ok license: ok license file: ok license field: ok spec language : ok spec legibility: ok upstream sources : ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok shared libs: ok system libs: ok relocatable: no directory ownership: ok duplicate files: ok file permissions: ok macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok base package: ok pkg-config files: ok libtool archives: ok directory ownership: ok utf8 filenames: ok Approved gui apps: ok New Package CVS Request ======================= Package Name: gnome-icon-theme-symbolic Short Description: Symbolic GNOME icons Owners: hadess Branches: F-13 CVS Done Built in rawhide, thanks. gnome-icon-theme-symbolic-2.30.0-3.fc14 |