Bug 587320 - Review Request: gnome-icon-theme-symbolic - Symbolic GNOME icons
Summary: Review Request: gnome-icon-theme-symbolic - Symbolic GNOME icons
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-04-29 15:32 UTC by Bastien Nocera
Modified: 2010-05-21 15:34 UTC (History)
4 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2010-05-21 15:34:42 UTC
mclasen: fedora-review+
dennis: fedora-cvs+


Attachments (Terms of Use)

Description Bastien Nocera 2010-04-29 15:32:43 UTC
Spec URL: http://people.fedoraproject.org/~hadess/gnome-icon-theme-symbolic/gnome-icon-theme-symbolic.spec
SRPM URL: http://people.fedoraproject.org/~hadess/gnome-icon-theme-symbolic/gnome-icon-theme-symbolic-2.30.0-1.fc12.src.rpm
Description: 
This package contains symbolic icons for use by the GNOME desktop.

Built package at:
http://people.fedoraproject.org/~hadess/gnome-icon-theme-symbolic/gnome-icon-theme-symbolic-2.30.0-1.fc12.noarch.rpm

The spec is the exact same as gnome-icon-theme-extras, which already passed review.

Comment 1 Matthias Clasen 2010-04-29 18:44:06 UTC
Note that gnome-icon-theme in rawhide does not have the scalable directories in index.theme, since I've kicked out all our non-upstream additions. You probably want to fix that both upstream and in rawhide.

Comment 2 Matthias Clasen 2010-04-29 20:31:12 UTC
Some more informal comments:

Requires(posttrans): gtk2 >= 2.6.2
Requires(postun): gtk2 >= 2.6.2

I believe we generally don't add this as a dep (thats one of the reasons for the ||: construct)



%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT

The rm -rf is no longer needed in %install



%clean
rm -rf $RPM_BUILD_ROOT

And neither is %clean

Comment 4 Matthias Clasen 2010-05-20 04:45:26 UTC
builds fine in mock
rpmlint output:
rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gnome-icon-theme-symbolic-2.30.0-2.fc14.noarch.rpm 
gnome-icon-theme-symbolic.noarch: W: no-url-tag
1 packages and 0 specfiles checked; 0 errors, 1 warnings.


package name: ok
spec file name: ok
packaging guidelines: ok
license: ok
license file: ok
license field: ok
spec language : ok
spec legibility: ok
upstream sources : ok
buildable: ok
excludearch: ok
buildrequires: ok
locale handling: ok
shared libs: ok
system libs: ok
relocatable: no
directory ownership: ok
duplicate files: ok
file permissions: ok
macro use: ok
permissible content: ok
large docs: ok
%doc content: ok
headers: ok
static libs: ok
shared libs: ok
base package: ok
pkg-config files: ok
libtool archives: ok
directory ownership: ok
utf8 filenames: ok

Approved
gui apps: ok

Comment 5 Bastien Nocera 2010-05-21 13:18:08 UTC
New Package CVS Request
=======================
Package Name: gnome-icon-theme-symbolic
Short Description: Symbolic GNOME icons
Owners: hadess
Branches: F-13

Comment 6 Dennis Gilmore 2010-05-21 15:18:26 UTC
CVS Done

Comment 7 Bastien Nocera 2010-05-21 15:34:42 UTC
Built in rawhide, thanks.

gnome-icon-theme-symbolic-2.30.0-3.fc14


Note You need to log in before you can comment on or make changes to this bug.