Bug 588477

Summary: Review Request: rubygem-webmock - mock object support for web dev in ruby.
Product: [Fedora] Fedora Reporter: Adam Young <ayoung>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DEFERRED QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, jesusr, mastahnke, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-18 14:45:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 588406    

Description Adam Young 2010-05-03 19:10:07 UTC
Spec URL: http://github.com/admiyo/MySpecs/blob/master/rubygem-webmock.spec
SRPM URL: http://admiyo.fedorapeople.org/buildr-repo/rubygem-webmock-0.9.1-1.young.src.rpm
Description: Library for stubbing HTTP requests in Ruby

Comment 1 Adam Young 2010-05-11 20:22:34 UTC
Updated withe standard changes: License, define->global, documentation deduplication, etc.

http://github.com/admiyo/MySpecs/blob/5819405848299b9cc794338dafcf788668732310/rubygem-rubyzip.spec

http://admiyo.fedorapeople.org/buildr-repo/rubygem-webmock-0.9.1-2.young.src.rpm

Comment 2 Michael Stahnke 2010-08-30 01:52:19 UTC
rubygem-sitelib is never used and should be removed. 

rubygem-webmock.noarch: E: version-control-internal-file /usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.gitignore



This can be removed rubygem-webmock.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.document

I'd like to have a full %check section, but it looks like the Rakefile requires jeweler.  There is a review bug open on that gem, and hopefully it will be included soon.  Until then, perhaps having a %check section that is commented out would be ok.

%check
cd %{buildroot}%{geminstdir}
rake test
rake spec

I'll have more comments after I review addressable and httpclient.  I open this one in the wrong order.

Comment 3 Jesus M. Rodriguez 2010-11-18 14:45:36 UTC
This initially started as a dependency for rubygem-buildr. It is no longer needed for that. We can cancel this review.