Bug 588477 - Review Request: rubygem-webmock - mock object support for web dev in ruby.
Review Request: rubygem-webmock - mock object support for web dev in ruby.
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
Depends On:
Blocks: buildr
  Show dependency treegraph
Reported: 2010-05-03 15:10 EDT by Adam Young
Modified: 2010-12-01 13:13 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-11-18 09:45:36 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Adam Young 2010-05-03 15:10:07 EDT
Spec URL: http://github.com/admiyo/MySpecs/blob/master/rubygem-webmock.spec
SRPM URL: http://admiyo.fedorapeople.org/buildr-repo/rubygem-webmock-0.9.1-1.young.src.rpm
Description: Library for stubbing HTTP requests in Ruby
Comment 1 Adam Young 2010-05-11 16:22:34 EDT
Updated withe standard changes: License, define->global, documentation deduplication, etc.


Comment 2 Michael Stahnke 2010-08-29 21:52:19 EDT
rubygem-sitelib is never used and should be removed. 

rubygem-webmock.noarch: E: version-control-internal-file /usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.gitignore

This can be removed rubygem-webmock.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/webmock-0.9.1/spec/vendor/samuel-0.2.1/.document

I'd like to have a full %check section, but it looks like the Rakefile requires jeweler.  There is a review bug open on that gem, and hopefully it will be included soon.  Until then, perhaps having a %check section that is commented out would be ok.

cd %{buildroot}%{geminstdir}
rake test
rake spec

I'll have more comments after I review addressable and httpclient.  I open this one in the wrong order.
Comment 3 Jesus M. Rodriguez 2010-11-18 09:45:36 EST
This initially started as a dependency for rubygem-buildr. It is no longer needed for that. We can cancel this review.

Note You need to log in before you can comment on or make changes to this bug.