Bug 592445

Summary:	Review Request: maven-pmd-plugin - Maven PMD Plugin
Product:	[Fedora] Fedora	Reporter:	Alexander Kurtakov <akurtako>
Component:	Package Review	Assignee:	Jeff Johnston <jjohnstn>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, jjohnstn, notting
Target Milestone:	---	Flags:	jjohnstn: fedora-review+ dennis: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-05-18 20:46:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexander Kurtakov 2010-05-14 21:09:52 UTC

Spec URL: http://akurtakov.fedorapeople.org/maven-pmd-plugin.spec
SRPM URL: http://akurtakov.fedorapeople.org/maven-pmd-plugin-2.5-1.fc13.src.rpm
Description: A Maven plugin for the PMD toolkit, that produces a report on both code rule violations and detected copy and paste fragments, as well as being able to fail the build based on these metrics.

Comment 1 Alexander Kurtakov 2010-05-14 21:16:39 UTC

Note about this package:
  It built successfully in koji with dist-f14-maven221 target: http://koji.fedoraproject.org/koji/taskinfo?taskID=2188813

Comment 2 Jeff Johnston 2010-05-14 21:25:03 UTC

Needs an epoch of 1 for the Provides statement.

rpmlint details:

bash $ rpmlint maven-pmd-plugin.spec
maven-pmd-plugin.spec: W: invalid-url Source0: maven-pmd-plugin-2.5.tar.xz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

bash $ rpmlint maven-pmd-plugin-2.5-1.fc14.noarch.rpm 
maven-pmd-plugin.noarch: W: no-documentation
maven-pmd-plugin.noarch: W: non-conffile-in-etc /etc/maven/fragments/maven-pmd-plugin
1 packages and 0 specfiles checked; 0 errors, 2 warnings

bash $ rpmlint maven-pmd-plugin-javadoc-2.5-1.fc14.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 3 Jeff Johnston 2010-05-14 21:29:20 UTC

Actually, on reflection, the epoch is not needed since the new version is higher than the old 2.0.8.  The other comments can be ignored.  The source tarball info is provided and the non-conffile message is extraneous.

Approved.

Comment 4 Alexander Kurtakov 2010-05-14 21:30:23 UTC

New Package CVS Request
=======================
Package Name: maven-pmd-plugin
Short Description: Maven PMD Plugin
Owners: akurtakov
Branches: 
InitialCC:

Comment 5 Dennis Gilmore 2010-05-18 18:30:42 UTC

CVS Done

BTW once an epoch is introduced it always needs to be there. so you do need it in the provides  otherwise the old package will be seen as newer

Comment 6 Alexander Kurtakov 2010-05-18 20:32:54 UTC

Dennis, this is not true because it has the correct epoch in the obsoletes thus it don't need it in the package itself.
package A without epoch can obsolete package B with epoch: 5 as long as the epoch of package B is used in the package A obsolete

P.S. Trust me I've checked that with a big number of packages

Comment 7 Alexander Kurtakov 2010-05-18 20:46:23 UTC

Fixed. Build in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2195001