Bug 592655
| Summary: | yelp-xsl XSL stylesheets for use with yelp | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> |
| Component: | Package Review | Assignee: | Matthew Barnes <mbarnes> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mbarnes, metherid, notting, panemade |
| Target Milestone: | --- | Flags: | mbarnes:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-17 14:44:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matthias Clasen
2010-05-16 00:19:12 UTC
rpmlint output: yelp-xsl.src: I: checking yelp-xsl.src: W: spelling-error Summary(en_US) stylesheets -> style sheets, style-sheets, stylishness yelp-xsl.src: W: spelling-error %description -l en_US stylesheets -> style sheets, style-sheets, stylishness yelp-xsl.src: W: non-standard-group Unspecified yelp-xsl.src: I: checking-url http://download.gnome.org/sources/yelp-xsl (timeout 10 seconds) yelp-xsl.src: W: no-cleaning-of-buildroot %install yelp-xsl.src: W: no-cleaning-of-buildroot %clean yelp-xsl.src: W: no-buildroot-tag yelp-xsl.src: W: no-%clean-section yelp-xsl.src: I: checking-url http://download.gnome.org/sources/yelp-xsl/2.31/yelp-xsl-2.31.1.tar.bz2 (timeout 10 seconds) Builds fine, md5sum of tarball matches upstream. "no-buildroot-tag" and "no-%clean-section" can be ignored per packaging guidelines. I guess the other cleaning warnings can be ignored too since there's nothing to clean. Not sure what the Group tag should be; yelp's is "Applications/System". I'll leave it to you to fix or ignore the spelling errors. I guess technically it's two words. Typo: missing opening brace for %{version} in devel package. Otherwise looks correct to me. As per http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps, you should use following make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > As per http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps, you should > use following > > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" I still have to find somebody who can explain a tangible benefit of this, other than giving reviewers the good feeling that they have something to criticize. New version http://mclasen.fedorapeople.org/yelp-xsl.spec http://mclasen.fedorapeople.org/yelp-xsl-2.31.1-2.fc14.src.rpm changes - use install -p - fix %version} typo - add Group tag Approved. The timestamp thing seems silly to me, but we comply. New Package CVS Request ======================= Package Name: yelp-xsl Short Description: XSL Stylesheets for yelp Owners: mclasen, mbarnes Branches: CVS Done Looks like this can be closed. |