Bug 592655 - yelp-xsl XSL stylesheets for use with yelp
yelp-xsl XSL stylesheets for use with yelp
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Matthew Barnes
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-05-15 20:19 EDT by Matthias Clasen
Modified: 2010-06-17 10:44 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-06-17 10:44:56 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mbarnes: fedora‑review+
dennis: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Matthias Clasen 2010-05-15 20:19:12 EDT
These are new stylesheets for use with yelp.
They are now shipped as a separate module.

http://mclasen.fedorapeople.org/yelp-xsl.spec
http://mclasen.fedorapeople.org/yelp-xsl-2.31.1-1.fc14.src.rpm
Comment 1 Matthew Barnes 2010-05-26 15:20:38 EDT
rpmlint output:
yelp-xsl.src: I: checking
yelp-xsl.src: W: spelling-error Summary(en_US) stylesheets -> style sheets, style-sheets, stylishness
yelp-xsl.src: W: spelling-error %description -l en_US stylesheets -> style sheets, style-sheets, stylishness
yelp-xsl.src: W: non-standard-group Unspecified
yelp-xsl.src: I: checking-url http://download.gnome.org/sources/yelp-xsl (timeout 10 seconds)
yelp-xsl.src: W: no-cleaning-of-buildroot %install
yelp-xsl.src: W: no-cleaning-of-buildroot %clean
yelp-xsl.src: W: no-buildroot-tag
yelp-xsl.src: W: no-%clean-section
yelp-xsl.src: I: checking-url http://download.gnome.org/sources/yelp-xsl/2.31/yelp-xsl-2.31.1.tar.bz2 (timeout 10 seconds)

Builds fine, md5sum of tarball matches upstream.

"no-buildroot-tag" and "no-%clean-section" can be ignored per packaging guidelines.

I guess the other cleaning warnings can be ignored too since there's nothing to clean.

Not sure what the Group tag should be; yelp's is "Applications/System".

I'll leave it to you to fix or ignore the spelling errors.  I guess technically it's two words.

Typo: missing opening brace for %{version} in devel package.

Otherwise looks correct to me.
Comment 2 Parag AN(पराग) 2010-05-26 23:20:46 EDT
As per http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps, you should use following

make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
Comment 3 Matthias Clasen 2010-05-27 09:54:47 EDT
> As per http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps, you should
> use following
>
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"   

I still have to find somebody who can explain a tangible benefit of this, other than giving reviewers the good feeling that they have something to criticize.
Comment 4 Matthias Clasen 2010-05-27 10:26:09 EDT
New version

http://mclasen.fedorapeople.org/yelp-xsl.spec
http://mclasen.fedorapeople.org/yelp-xsl-2.31.1-2.fc14.src.rpm  

changes
- use install -p
- fix %version} typo
- add Group tag
Comment 5 Matthew Barnes 2010-05-27 11:32:35 EDT
Approved.  The timestamp thing seems silly to me, but we comply.
Comment 6 Matthias Clasen 2010-05-27 15:14:11 EDT
New Package CVS Request
=======================
Package Name: yelp-xsl
Short Description: XSL Stylesheets for yelp
Owners: mclasen, mbarnes
Branches:
Comment 7 Dennis Gilmore 2010-05-27 18:37:07 EDT
CVS Done
Comment 8 Matthew Barnes 2010-06-17 10:44:56 EDT
Looks like this can be closed.

Note You need to log in before you can comment on or make changes to this bug.