Bug 592799

Summary: syntax mistake in /etc/bashrc pathmunge
Product: [Fedora] Fedora Reporter: Aron Griffis <aron>
Component: setupAssignee: Ondrej Vasik <ovasik>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 13CC: ovasik, pknirsch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 592825 (view as bug list) Environment:
Last Closed: 2010-05-24 13:22:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 592825    
Attachments:
Description Flags
fix it none

Description Aron Griffis 2010-05-17 02:14:40 UTC
Created attachment 414438 [details]
fix it

Description of problem:
pathmunch in /etc/bashrc quotes the regex. Current versions of bash require the regex to be unquoted (just like glob-matching), so the regex will never match. Note the var $1 should still be quoted to prevent interpretation of regex chars.

Version-Release number of selected component (if applicable):
setup-2.8.17-1.fc13.noarch

Actual results:
$PATH with dups

Expected results:
$PATH without dups

Comment 1 Ondrej Vasik 2010-05-17 05:46:31 UTC
Thanks for report, I see - changed between 3.1 and 3.2 . Will fix that...

Comment 2 Ondrej Vasik 2010-05-19 10:27:08 UTC
Fixed in setup-2.8.19-1.fc14 ...

Comment 3 Ondrej Vasik 2010-05-24 13:22:53 UTC
I used a bit different approach - no bashism, case is used - it seems to be even faster (and from my tests even a bit better for some obscure PATHs). As this change is no longer required, I'll mark this bugzilla as NEXTRELEASE.

See https://bugzilla.redhat.com/show_bug.cgi?id=544652 for the setup package updates which do contain the new patmunge() with case.