Bug 593280

Summary:	Review Request: servicelog - Servicelog Tools
Product:	[Fedora] Fedora	Reporter:	Roman Rakus <rrakus>
Component:	Package Review	Assignee:	Kamil Dudka <kdudka>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, kdudka, notting, rrakus, tsmetana
Target Milestone:	---	Flags:	rrakus: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	servicelog-1.1.7-1.fc14	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-31 11:49:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Roman Rakus 2010-05-18 12:23:49 UTC

SPEC URL: http://rrakus.fedorapeople.org/servicelog.spec
SRPM URL: http://rrakus.fedorapeople.org/servicelog-1.1.7-1.fc11.src.rpm
Description:
Command-line interfaces for viewing and manipulating the contents of
the servicelog database. Contains entries that are useful
for performing system service operations, and for providing a history
of service operations that have been performed on the system.

Comment 1 Kamil Dudka 2010-05-18 12:51:44 UTC

Fedora Merge Review: servicelog

http://cvs.fedoraproject.org/viewvc/devel/libservicelog

Comment 2 Kamil Dudka 2010-05-18 12:54:38 UTC

(In reply to comment #1)
> Fedora Merge Review: servicelog

s/servicelog/libservicelog/

Comment 3 Kamil Dudka 2010-05-18 13:09:07 UTC

Sorry for the mess above.  This bug is for review of servicelog (not libservicelog)...

Comment 4 Kamil Dudka 2010-05-19 11:16:06 UTC

+ silent rpmlint
+ valid source URL and project URL
+ dist tag OK
+ BuildRoot tag OK
+ license tag OK
+ no downstream patches for now
+ configure OK
+ make OK
+ %install OK
+ %clean OK
+ %files OK
- I wonder why the upstream tarball is not already bootstrapped
- also the CVS directories look there redundant to me
- some warnings during build on ppc64 as follows:

    warning: format '%llu' expects type 'long long unsigned int', but argument 2 has type 'uint64_t'

They seem to be false alarms since sizeof(unsigned long long) == sizeof(unit64_t) == 8.

Overall the package looks sane.

Comment 5 Roman Rakus 2010-05-19 16:28:23 UTC

I have forgot to set flags. Setting fedora-review flag to + (see comment 4).

Comment 6 Roman Rakus 2010-05-20 12:23:50 UTC

New Package CVS Request
=======================
Package Name: servicelog
Short Description: Servicelog Tools
Owners: rrakus
Branches: rawhide
InitialCC:

Comment 7 Kevin Fenzi 2010-05-20 19:40:14 UTC

CVS done (by process-cvs-requests.py).

Comment 8 Kamil Dudka 2010-08-31 11:49:52 UTC

servicelog-1.1.7-1.fc14 is already out, closing RAWHIDE