Red Hat Bugzilla – Bug 593280
Review Request: servicelog - Servicelog Tools
Last modified: 2014-01-12 19:11:42 EST
SPEC URL: http://rrakus.fedorapeople.org/servicelog.spec
SRPM URL: http://rrakus.fedorapeople.org/servicelog-1.1.7-1.fc11.src.rpm
Command-line interfaces for viewing and manipulating the contents of
the servicelog database. Contains entries that are useful
for performing system service operations, and for providing a history
of service operations that have been performed on the system.
Fedora Merge Review: servicelog
(In reply to comment #1)
> Fedora Merge Review: servicelog
Sorry for the mess above. This bug is for review of servicelog (not libservicelog)...
+ silent rpmlint
+ valid source URL and project URL
+ dist tag OK
+ BuildRoot tag OK
+ license tag OK
+ no downstream patches for now
+ configure OK
+ make OK
+ %install OK
+ %clean OK
+ %files OK
- I wonder why the upstream tarball is not already bootstrapped
- also the CVS directories look there redundant to me
- some warnings during build on ppc64 as follows:
warning: format '%llu' expects type 'long long unsigned int', but argument 2 has type 'uint64_t'
They seem to be false alarms since sizeof(unsigned long long) == sizeof(unit64_t) == 8.
Overall the package looks sane.
I have forgot to set flags. Setting fedora-review flag to + (see comment 4).
New Package CVS Request
Package Name: servicelog
Short Description: Servicelog Tools
CVS done (by process-cvs-requests.py).
servicelog-1.1.7-1.fc14 is already out, closing RAWHIDE