Bug 595455

Summary: rgmanager does not remove nfs service temp directories when using nfslock=1
Product: Red Hat Enterprise Linux 5 Reporter: Carlos Maiolino <cmaiolin>
Component: rgmanagerAssignee: Lon Hohberger <lhh>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.5CC: cluster-maint, edamato, sbradley, tao, tdunnon
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: rgmanager-2.0.52-6.13.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-01-13 23:26:23 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
create temp dirs only after the script pass the first if conditions lhh: review+

Description Carlos Maiolino 2010-05-24 16:38:02 UTC 
Description of problem:

when using nfslock=1, rgmanager does not remove temp directories (statd-*) created on /tmp when they are no longer needed.

Version-Release number of selected component (if applicable):

rgmanager-2.0.52-6.el5

How reproducible:
Always

Steps to Reproduce:
1. Setup a simple NFS cluster (2-node is enough)
2. Setup a simple nfs service setting nfslock=1
3. Start nfs service in any node and statd-* directories are created on /tmp of that node.
4. Stop nfs service on the node and the statd-* directories are not removed.
  
Actual results:

Temp directories are not removed from /tmp directory

Expected results:

Directories are removed when not necessary.

Additional info:

Temp directories are created by /usr/share/cluster/svclib_nfslock script, which should remove these files at the end of the script.
But, if the script return on one of the first 'if' instructions, the temp directories are not removed.
Comment 1 Carlos Maiolino 2010-05-24 16:42:23 UTC 
Created attachment 416172 [details]
create temp dirs only after the script pass the first if conditions

If the script creates the temp directories only after pass by the if conditions, the temp directories are properly removed.
Comment 2 Lon Hohberger 2010-05-26 19:49:05 UTC 
The patch is correct.
Comment 3 Lon Hohberger 2010-07-29 17:53:31 UTC 
http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=a8d21b2f0ccb2b9b50f4e729e070fec0fcfd8fee
Comment 5 errata-xmlrpc 2011-01-13 23:26:23 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0134.html